Optimize page tree rendering performance #3606
Merged
+69
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Pre-compute URL templates once at the class level and substitute page IDs
using simple string operations instead of calling Rails URL helpers for
each page. This reduces the overhead of route matching which was showing
up as a significant portion of render time in profiling.
For a tree with 1000 pages, this reduces render time from ~725ms to ~420ms
(approximately 40% improvement).
Cache repeated translation lookups in a frozen hash at the class level.
Translations like "Your user role does not allow you to edit this page"
were being looked up 6 times per page (6000 times for 1000 pages).
Combined with the URL optimization, render time for 1000 pages improves
from ~725ms to ~330ms (approximately 54% faster).
Checklist