fix: Filter nested elements by visibility when publishing pages #3593
+48
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3593 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 314 314
Lines 8187 8189 +2
=======================================
+ Hits 7978 7980 +2
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
backport-nested-elements-filter-8.0
branch
from
025363c to
a24511d
Compare
tvdeyen
changed the title
When publishing a page, only visible top-level elements were being filtered. Nested elements were copied regardless of their public status, which meant hidden nested elements would appear on the published version. This adds a publishable_only option to DuplicateElement that filters nested elements through the repository's visible method, ensuring only public nested elements are copied to the published version. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
backport-nested-elements-filter-8.0
branch
from
a24511d to
adac074
Compare
3 tasks
sascha-karnatz
approved these changes
Jan 26, 2026
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
When publishing a page, only visible top-level elements were being filtered. Nested elements were copied regardless of their public status, which meant hidden nested elements would appear on the published version.
This adds a
publishable_onlyoption toDuplicateElementthat filters nested elements through the repository'svisiblemethod, ensuring only public nested elements are copied to the published version.Checklist