Closed
Conversation
Owner
|
This only covers some of the necessary changes, I'll incorporate the update to Cheers, Alan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_snp_loc_data.R
Added support for a dbSNP_tarball argument: if a path is provided, we unpack the package bundle into a temp directory and load the OnDiskLongTable directly from its inst/extdata folder.
Otherwise fall back to loading the installed SNPlocs.Hsapiens.dbSNP.GRCh<37|38> Bioconductor package.
validate_parameters.R
Introduced skip_pkg_checks <- !is.null(dbSNP_tarball) so that when a tarball is supplied we skip the SNPlocs/BSgenome package–installation checks.
Added early validation for a missing or non-existent tarball path.
Moved the numeric‐only dbSNP check outside of the “skip” block, so invalid values always error out immediately.
format_sumstats.R
Passed dbSNP_tarball through into load_snp_loc_data() and all downstream SNPlocs‐dependent checks.
Ensured that when a tarball is provided, neither validate_parameters() nor the loader will try to require an installed SNPlocs.Hsapiens.* package.