Draft
Conversation
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This PR introduces the first implementation of the Cloud Device API, which is a significant and well-structured addition. The new service, configuration updates, and tests are comprehensive for a first iteration. I have identified a few areas for improvement, primarily concerning configuration consistency, code simplification for maintainability, and naming conventions in the new typings to enhance clarity.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gcatanese
force-pushed
the
cloud-devices-api
branch
from
4ebc323 to
6c00487
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
gcatanese
force-pushed
the
cloud-devices-api
branch
from
f120890 to
7e82688
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the first implementation of the Cloud device API:
POST
https://<Base-URL>/v1/merchants/{merchantAccount}/devices/{deviceId}/syncPOST
https://<Base-URL>/v1/merchants/{merchantAccount}/devices/{deviceId}/asyncGET
https://<Base-URL>/v1/merchants/{merchantAccount}/devices/{deviceId}/statusGET
https://<Base-URL>/v1/merchants/{merchantAccount}/connectedDevicesConfigandClientto define Cloud device region-based endpoints/syncandasyncendpoints