Draft
Conversation
これにより changeIcon の各 querySelector は二度以上走らないようになった
そもそも UX にあまり影響しないと判断し、無駄な MutationObserver を減らす方向で動きたい 私の環境では MutationObserver が必要になる二度以上の要素書き換えを再現することはできなかったが、おま環なら戻してください ちなみに歴史的経緯としては、e06bf61 が最古な気がする……
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
無駄な MutationObserver を減らすのと、CSS を控える方向で動きたいけど難しそう
今のところ DOM 変更に伴う CSS 再計算が重いんじゃないかと考えてる
特に DevTools の Performance タブでは
[出典不明]が多くて、その中で「確定」「Microtasks の実行」「スクリプトの評価」「イベント: visibilitychange」などは目につく何しろ DOM 要素が多くてかなり厳しい