TST: seed the remaining noisy sensor fixtures#14
Merged
Conversation
Following @zuorenchen's review note on #13, seed the remaining noisy sensor fixtures (noisy_rotated_accelerometer, noisy_rotated_gyroscope) the same way noisy_barometer already is, so the whole sensor suite is deterministic instead of relying on statistical tolerance bounds. Uses the seed argument added in #13.
zuorenchen
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13, addressing @zuorenchen's review note: seed the other two noisy sensor fixtures (noisy_rotated_accelerometer, noisy_rotated_gyroscope) the same way noisy_barometer already is, so the whole sensor test suite is deterministic instead of relying on loose statistical tolerances. Uses the per-sensor seed argument added in #13.
Verified locally: both fixtures' tests pass deterministically (run repeatedly), the full tests/unit/sensors suite is 42 passed, ruff + pylint clean (10.00/10).