SmallMatrix operator*= for MM#4880
Closed
ax3l wants to merge 1 commit intoAMReX-Codes:developmentfrom
Closed
Conversation
Add a short-hand to multiply `SmallMatrix` with another value and assign the result.
Member
|
This only makes sense for square matrix, because the number of rows and cols are part of the type. So we should make that clear with enable_if when defining the function. We might also want to enforce that they have the same order and starting index. |
Member
Author
|
Ah you are totally right. Will improve accordingly. |
Member
Author
|
Don't need it after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a short-hand to multiply
SmallMatrixwith another value and assign the result.Additional background
Often useful in ImpactX, e.g., latest is BLAST-ImpactX/impactx#1256
Checklist
The proposed changes: