ParmParse: Print parsed values as comments in prettyPrint#4827
Merged
WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom Jan 21, 2026
Merged
ParmParse: Print parsed values as comments in prettyPrint#4827WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom
Conversation
Member
Author
Below is an example of the difference of the prettyPrint output. ``` < electrons.charge = -q_e # -1.6021766339999999e-19 < electrons.density = n0 # 9.9999999999999992e+22 --- > electrons.charge = -q_e > electrons.density = n0 ```
WeiqunZhang
force-pushed
the
pp_evaled
branch
from
21eca10 to
ec1881d
Compare
Member
Author
|
I think pyamrex tests failed because previously the type hint was not fully implemented. |
asalmgren
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below is an example of the difference of the prettyPrint output.