fix: prevent RuntimeError when filtering financials in FinnHubUtils #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug in
FinnHubUtils.get_basic_financials()that causes aRuntimeErrorwhenselected_columnsis provided.The Bug
The original code modified a dictionary while iterating over its keys:
The Fix
Replace the problematic loop with a dict comprehension that creates a new filtered dictionary:
Test plan
FinnHubUtils.get_basic_financials("AAPL", selected_columns=["eps", "pe"])no longer crashes