unwrap () has been replaced with meaning lib:afl errors and proper error propagation across the corpus folder wherever it is required #1908 #3696
Conversation
…r propagation across the corpus folder whereever it is required AFLplusplus#1908
| .pop_front() | ||
| .ok_or_else(|| { | ||
| Error::illegal_state( | ||
| "Cache eviction: VecDeque empty despite length check", |
| if let Some(prev_node) = self.map.get_mut(&prev) { | ||
| prev_node.next = item.next; | ||
| } else { | ||
| debug_assert!(false, "List corrupted: prev {prev} missing"); |
There was a problem hiding this comment.
what's a debug assert? Did you vibe code this?
There was a problem hiding this comment.
Sorry for this,as I was a newbie ,I really couldn't get where to start , I was just willing to make contributions, so I have used vibe coding 😆
If you could give some examples, it would be more helpful for me.
There was a problem hiding this comment.
No vibe coding is allowed https://github.com/AFLplusplus/LibAFL/blob/main/CONTRIBUTING.md#on-ai-assistance
There was a problem hiding this comment.
Ok sorry for that, please can you give some examples, so that I can know what type of error message can be replaced instead of unwrap as per requirement.
| fn add(&mut self, testcase: Testcase<I>) -> Result<CorpusId, Error> { | ||
| let id = self.inner.add(testcase)?; | ||
| let testcase = &mut self.get(id).unwrap().borrow_mut(); | ||
| let testcase = &mut self.get(id)?.borrow_mut(); |
There was a problem hiding this comment.
Can you explain to me how this could ever happen? we liteally just added it
|
Sorry. Some of the changes might be actually useful and correct, but so far all that I looked at did not appear to be? There's no point in blindly applying rules for code paths that can never happen. |
3 participants
Description
unwrap () has been replaced with meaningful libafl::errors and proper error handling across corpus folder, mainly the changed files are,
Checklist
./scripts/precommit.shand addressed all comments