Skip to content

Conversation

@Aditya30ag
Copy link
Contributor

Description

This PR updates the documentation to clarify the minimum supported Rust version (1.89.0) and adds instructions to update Rust using rustup update stable when an older version is installed.

Checklist

  • I have run ./scripts/precommit.sh and addressed all comments

@domenukk
Copy link
Member

domenukk commented Jan 5, 2026

I fear that we'll forget about updating the rust version in docs when we push the min version :D

@Aditya30ag
Copy link
Contributor Author

your point is absolutely valid we can do one thing instead explicitly point one version we can ask to update the rust version if it become old

@domenukk
Copy link
Member

domenukk commented Jan 6, 2026

We shoudl eitehr check it's the same as in
https://github.com/AFLplusplus/LibAFL/blob/4d0a5dabda6d70538a6696a1f779a34d3a656dce/crates/libafl/Cargo.toml#L15or just leave it out all together I think

@Aditya30ag
Copy link
Contributor Author

Aditya30ag commented Jan 6, 2026

Yes sir ,
Instead of hard-coding a Rust version in the docs we can ensure it always matches the version specified in LibAFL’s Cargo.toml, which is the real technical constraint.
or
we can also use this line - If your Rust version is too old, update it using rustup update stable.

@domenukk
Copy link
Member

domenukk commented Jan 6, 2026

yeah just a simple info is fine. Anyd maybe link to the cargo.toml of libafl crate so it's easy to check what the current min version is

@Aditya30ag
Copy link
Contributor Author

image

Is this correct

@domenukk
Copy link
Member

domenukk commented Jan 7, 2026

older than the one listed in Cargo.toml, ...

otherwise looks good! :)

@Aditya30ag Aditya30ag force-pushed the docs/add-rust-version-requirement branch from 9559965 to ca9c5f0 Compare January 7, 2026 13:59
@Aditya30ag
Copy link
Contributor Author

@domenukk sir done the all changes

@domenukk domenukk merged commit 5aa201e into AFLplusplus:main Jan 7, 2026
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants