fix: validate and auto-fix base_url protocol prefix#603
Open
JasonOA888 wants to merge 1 commit into666ghj:mainfrom
Open
fix: validate and auto-fix base_url protocol prefix#603JasonOA888 wants to merge 1 commit into666ghj:mainfrom
JasonOA888 wants to merge 1 commit into666ghj:mainfrom
Conversation
- Added _validate_base_url method to LLMClient classes - Auto-prepends 'https://' if base_url missing protocol prefix - Warns user about misconfiguration - Fixes 'Request URL is missing http:// or https://' error Error case: - User sets MEDIA_ENGINE_BASE_URL=api.example.com - Before: OpenAI client fails with protocol error - After: Auto-fixed to https://api.example.com with warning Fixes 666ghj#602
dosubot
bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #602 - 验证并自动修复 LLM base_url 缺少协议前缀的问题。
Problem
用户配置
MEDIA_ENGINE_BASE_URL=api.example.com时，OpenAI 客户端会报错：Solution
_validate_base_url方法验证 base_urlhttp://或https://前缀，自动补全https://Changes
MediaEngine/llms/base.py: 添加 base_url 验证InsightEngine/llms/base.py: 添加 base_url 验证Example
Fixes #602