FIX: refactor engine builders by viktor-shnaider · Pull Request #727 · 51Degrees/device-detection-dotnet

viktor-shnaider · 2026-04-07T14:59:05Z

Problem

PipelineBuilder.BuildFromConfiguration uses GetRuntimeMethods() to locate a builder's Build() method at runtime. When a builder declares public new Build() to hide the inherited protected virtual Build() from SingleFileAspectEngineBuilderBase, reflection sees both methods and throws a "multiple matching Build methods" error at startup.

Changes

RobotsTxtBuilder and PropertyKeyedDeviceEngineBaseBuilder: changed public new Build() to protected override Build() so the base method is replaced rather than hidden — reflection now finds exactly one parameterless Build()
RobotsTxtEngine: completed the IOnPremiseAspectEngine members that previously threw NotImplementedException:
RefreshData (both overloads) — no-op; data comes from DeviceDetectionHashEngine via AddPipeline, not a file
GetDataFileMetaData — returns null; no data files are registered
AddDataFile — throws NotSupportedException; data files are not applicable
TempDataDirPath — changed to null

Tests

RobotsTxtBuilderTests and PropertyKeyedBuilderTests: regression tests that call GetRuntimeMethods() directly and assert exactly one parameterless Build() is visible — will fail if public new is reintroduced
Utils.AssertSingleParameterlessBuild: shared helper in TestHelpers for reuse across builder test classes

… unit tests for builder structure

…ativeEngineBuilder

… to use the TacEngineBuilder. This highlights a failure which needs to be addressed.

jwrosewell

See the changes in the commit I've made to this branch.

I don't understand why the test isn't using the builder. I changed to use the builder for TacEngine and it requires parameters that are unneeded. This suggests the base class is wrong. It is just a simple FlowElement.

I have removed duplicate code and added a place holder for the new problem associated with the builders for Native and TAC using the same element key value.

jwrosewell · 2026-04-08T14:26:30Z

FiftyOne.DeviceDetection.PropertyKeyed/FlowElements/NativeEngineBuilder.cs

            base(loggerFactory, dataUpdateService)
        {
-            _elementDataKey = "native-profiles";
+            _elementDataKey = "hardware";


What happens if evidence is provided for Native and TAC in the same request? Sharing the same element key seems like it would create problems.

Currently, if we make three separate requests — one with TAC evidence, one with Native evidence, and one with both — all profiles will be created under the hardware property.

For example: https://cloud.51degrees.com/api/v4/{resourceKey}.json?TAC=35189711&nativemodel=iPhone11,8

Therefore, to maintain backward compatibility, _elementDataKey is set to "hardware" in both NativeEngineBuilder.cs and TacEngineBuilder.cs.

Please let me know if I misunderstood anything or if this needs correction.

Per James: please complete the combined test that was added as a stub in James's commit - so that we confirm that it works exactly as is in the current cloud so we preserve the logic.

jwrosewell · 2026-04-08T14:26:46Z

FiftyOne.DeviceDetection.PropertyKeyed/FlowElements/TacEngineBuilder.cs

            base(loggerFactory, dataUpdateService)
        {
-            _elementDataKey = "tac-profiles";
+            _elementDataKey = "hardware";


See comment against the native engine.

Currently, if we make three separate requests — one with TAC evidence, one with Native evidence, and one with both — all profiles will be created under the hardware property.

For example: https://cloud.51degrees.com/api/v4/{resourceKey}.json?TAC=35189711&nativemodel=iPhone11,8

Therefore, to maintain backward compatibility, _elementDataKey is set to "hardware" in both NativeEngineBuilder.cs and TacEngineBuilder.cs.

Please let me know if I misunderstood anything or if this needs correction.

jwrosewell · 2026-04-08T14:52:13Z

Overall I think deriving the base class from OnPremiseAspectEngineBase is the root cause of many problems.

public abstract class PropertyKeyedEngine<TData, TProfile> : OnPremiseAspectEngineBase<TData, IFiftyOneAspectPropertyMetaData>, IDisposable where TData : IMultiProfileData<TProfile> where TProfile : IAspectData

… profile aggregation

…hods

justadreamer

still some cleanup is left to do

justadreamer · 2026-04-09T13:35:52Z

FiftyOne.DeviceDetection.PropertyKeyed/FlowElements/PropertyKeyedDeviceBaseEngine.cs

            }
+            if (indexedProperties == null || indexedProperties.Count == 0)


was moved into the base class in pipeline-dotnet, so this can be removed here

justadreamer · 2026-04-09T13:37:06Z

FiftyOne.DeviceDetection.PropertyKeyed/FlowElements/PropertyKeyedDeviceEngineBaseBuilder.cs


        /// <inheritdoc/>
-        public override TBuilder SetPerformanceProfile(
+        public TBuilder SetPerformanceProfile(


This should be removed, we are getting data from the upstream engine in the pipeline.

justadreamer · 2026-04-09T13:37:19Z

FiftyOne.DeviceDetection.PropertyKeyed/FlowElements/PropertyKeyedDeviceEngineBaseBuilder.cs

        /// <returns>This builder.</returns>
-        public PropertyKeyedDeviceEngineBaseBuilder<TBuilder, TEngine> 
-            SetConcurrency(ushort concurrency)
+        public TBuilder SetConcurrency(ushort concurrency)


see above re: SetPerformanceProfile

justadreamer · 2026-04-09T13:42:20Z

FiftyOne.DeviceDetection.RobotsTxt/FlowElements/RobotsTxtEngine.cs

            _requiredProperties;

-        public IReadOnlyList<IAspectEngineDataFile> DataFiles => throw new NotImplementedException();
+        public IReadOnlyList<IAspectEngineDataFile> DataFiles => [];


why is this still needed? since we inherit from AspectEngineBase rather than OnPremiseAspectEngineBase

justadreamer · 2026-04-09T13:42:33Z

FiftyOne.DeviceDetection.RobotsTxt/FlowElements/RobotsTxtEngine.cs

+        /// Returns <see langword="null"/>. <see cref="RobotsTxtEngine"/> has no
+        /// data files of its own so there is no temp directory to configure.
+        /// </summary>
+        public string TempDataDirPath => null;


same question as re: DataFiles?

justadreamer · 2026-04-09T13:45:47Z

FiftyOne.DeviceDetection.RobotsTxt/FlowElements/RobotsTxtEngine.cs

+        /// it derives its data from <see cref="DeviceDetectionHashEngine"/> via
+        /// <see cref="AddPipeline"/> and has nothing to reload from disk.
+        /// </summary>
+        public void RefreshData(string dataFileIdentifier) { }


RefreshData probably needs to go too?

justadreamer · 2026-04-09T13:46:00Z

FiftyOne.DeviceDetection.RobotsTxt/FlowElements/RobotsTxtEngine.cs

+        /// Returns <see langword="null"/>. <see cref="RobotsTxtEngine"/> has no
+        /// data files, so there is no metadata to return for any identifier.
+        /// </summary>
+        public IAspectEngineDataFile GetDataFileMetaData(


this all needs to be cleaned out

… update CombinedTests

github-actions · 2026-04-10T07:50:16Z

Unit Tests - Mac_arm64_Release

4 files ±0 4 suites ±0 2m 8s ⏱️ ±0s
215 tests +2 192 ✅ +4 23 💤 - 2 0 ❌ ±0
258 runs +2 235 ✅ +4 23 💤 - 2 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEngines_UseSameElementDataKey
FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEvidence_AggregatesProfilesUnderHardware
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ NativeEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ TacEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

This pull request removes 3 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

github-actions · 2026-04-10T07:50:28Z

Integration Tests - Mac_arm64_Release

0 files - 12 0 suites - 12 0s ⏱️ - 22m 6s
0 tests - 348 0 ✅ - 345 0 💤 - 3 0 ❌ ±0
0 runs - 696 0 ✅ - 690 0 💤 - 6 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:51:12Z

Unit Tests - Mac_x64_Release

4 files ±0 4 suites ±0 2m 25s ⏱️ -7s
215 tests +2 192 ✅ +4 23 💤 - 2 0 ❌ ±0
258 runs +2 235 ✅ +4 23 💤 - 2 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEngines_UseSameElementDataKey
FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEvidence_AggregatesProfilesUnderHardware
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ NativeEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ TacEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

This pull request removes 3 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

github-actions · 2026-04-10T07:51:28Z

Integration Tests - Mac_x64_Release

0 files - 12 0 suites - 12 0s ⏱️ - 25m 45s
0 tests - 348 0 ✅ - 345 0 💤 - 3 0 ❌ ±0
0 runs - 696 0 ✅ - 690 0 💤 - 6 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:51:46Z

Unit Tests - Ubuntu_x64_Release

4 files ±0 4 suites ±0 1m 40s ⏱️ -4s
215 tests +2 192 ✅ +4 23 💤 - 2 0 ❌ ±0
258 runs +2 235 ✅ +4 23 💤 - 2 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEngines_UseSameElementDataKey
FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEvidence_AggregatesProfilesUnderHardware
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ NativeEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ TacEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

This pull request removes 3 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

github-actions · 2026-04-10T07:51:55Z

Unit Tests - Ubuntu_x64_Debug

4 files ±0 4 suites ±0 1m 40s ⏱️ -7s
215 tests +2 192 ✅ +4 23 💤 - 2 0 ❌ ±0
258 runs +2 235 ✅ +4 23 💤 - 2 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEngines_UseSameElementDataKey
FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEvidence_AggregatesProfilesUnderHardware
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ NativeEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ TacEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

This pull request removes 3 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

github-actions · 2026-04-10T07:51:57Z

Integration Tests - Ubuntu_x64_Release

0 files - 12 0 suites - 12 0s ⏱️ - 4m 23s
0 tests - 348 0 ✅ - 345 0 💤 - 3 0 ❌ ±0
0 runs - 696 0 ✅ - 690 0 💤 - 6 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:52:05Z

Integration Tests - Ubuntu_x64_Debug

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:52:08Z

Performance Tests - Ubuntu_x64_Release

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:53:05Z

Unit Tests - Ubuntu_ARM_Release

4 files ±0 4 suites ±0 1m 37s ⏱️ +4s
215 tests +2 192 ✅ +4 23 💤 - 2 0 ❌ ±0
258 runs +2 235 ✅ +4 23 💤 - 2 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEngines_UseSameElementDataKey
FiftyOne.DeviceDetection.PropertyKeyed.Tests.CombinedTests ‑ BothEvidence_AggregatesProfilesUnderHardware
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ NativeEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.PropertyKeyedBuilderTests ‑ TacEngineBuilder_SingleParameterlessBuildMethod
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

This pull request removes 3 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

FiftyOne.DeviceDetection.PropertyKeyed.Tests.CustomPropertyEngineTests ‑ RefreshData_Throws
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsUnique
FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ RefreshData_Throws

FiftyOne.DeviceDetection.PropertyKeyed.Tests.TacConfiguredEngineTests ‑ ElementDataKey_IsHardware

github-actions · 2026-04-10T07:53:13Z

Unit Tests - Windows_x64_Debug

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:53:16Z

Integration Tests - Ubuntu_ARM_Release

0 files - 12 0 suites - 12 0s ⏱️ - 3m 52s
0 tests - 348 0 ✅ - 345 0 💤 - 3 0 ❌ ±0
0 runs - 696 0 ✅ - 690 0 💤 - 6 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:53:27Z

Integration Tests - Windows_x64_Debug

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:53:28Z

Performance Tests - Ubuntu_ARM_Release

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:55:21Z

Unit Tests - Windows_x64_Release

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:55:34Z

Integration Tests - Windows_x64_Release

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites - 2 0 💤 ±0
0 files - 2 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:55:47Z

Performance Tests - Windows_x64_Release

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:56:23Z

Unit Tests - Windows_x86_Debug

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:56:35Z

Integration Tests - Windows_x86_Debug

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:56:55Z

Unit Tests - Windows_x86_Release

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

github-actions · 2026-04-10T07:57:08Z

Integration Tests - Windows_x86_Release

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites - 2 0 💤 ±0
0 files - 2 0 ❌ ±0

Results for commit 9210209. ± Comparison against base commit 96ce45d.

FIX: refactor engine builders to use protected Build() method and add…

22a8a5e

… unit tests for builder structure

viktor-shnaider requested review from drasmart and justadreamer April 7, 2026 14:59

viktor-shnaider self-assigned this Apr 7, 2026

FIX: Update element data keys to "hardware" in TacEngineBuilder and N…

1f91c15

…ativeEngineBuilder

justadreamer requested review from jwrosewell and removed request for drasmart April 7, 2026 18:03

jwrosewell added 2 commits April 8, 2026 15:48

TEST: Used a base class to avoid duplicate code. Changed the TAC test…

d3f3ce7

… to use the TacEngineBuilder. This highlights a failure which needs to be addressed.

BUG: Check that the IndexedProperties contains values.

757d4a0

jwrosewell requested changes Apr 8, 2026

View reviewed changes

justadreamer assigned YaroslavVlasenko Apr 9, 2026

YaroslavVlasenko added 2 commits April 9, 2026 12:55

TEST: Add unit tests to verify shared "hardware" element data key and…

9ba9770

… profile aggregation

REFACT: Remove unused IDataUpdateService dependencies and related met…

40ac25d

…hods

justadreamer requested changes Apr 9, 2026

View reviewed changes

viktor-shnaider added 2 commits April 9, 2026 17:18

Merge branch 'main' into fix/engine-builders

a660f2b

refactor: clean up PropertyKeyedDeviceBaseEngine and RobotsTxtEngine;…

9210209

… update CombinedTests

justadreamer approved these changes Apr 10, 2026

View reviewed changes

YaroslavVlasenko approved these changes Apr 10, 2026

View reviewed changes

justadreamer merged commit 1962d92 into main Apr 10, 2026
34 checks passed

justadreamer deleted the fix/engine-builders branch April 10, 2026 07:59

		}
		if (indexedProperties == null \|\| indexedProperties.Count == 0)

Conversation

viktor-shnaider commented Apr 7, 2026

Problem

Changes

Tests

Uh oh!

jwrosewell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwrosewell commented Apr 8, 2026

Uh oh!

justadreamer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 10, 2026

Unit Tests - Mac_arm64_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Integration Tests - Mac_arm64_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Unit Tests - Mac_x64_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Integration Tests - Mac_x64_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Unit Tests - Ubuntu_x64_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Unit Tests - Ubuntu_x64_Debug

Uh oh!

github-actions bot commented Apr 10, 2026

Integration Tests - Ubuntu_x64_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Integration Tests - Ubuntu_x64_Debug

Uh oh!

github-actions bot commented Apr 10, 2026

Performance Tests - Ubuntu_x64_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Unit Tests - Ubuntu_ARM_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Unit Tests - Windows_x64_Debug

Uh oh!

github-actions bot commented Apr 10, 2026

Integration Tests - Ubuntu_ARM_Release

Uh oh!

github-actions bot commented Apr 10, 2026

Integration Tests - Windows_x64_Debug

Uh oh!

github-actions bot commented Apr 10, 2026

Performance Tests - Ubuntu_ARM_Release

Uh oh!