Prevent wrong-platform native DLL from overriding Linux publish output#722
Merged
Automation51D merged 2 commits intomainfrom Apr 10, 2026
Merged
Prevent wrong-platform native DLL from overriding Linux publish output#722Automation51D merged 2 commits intomainfrom
Automation51D merged 2 commits intomainfrom
Conversation
justadreamer
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dotnet publish -r linux-x64produced a Windows PE32+ DLL instead of a Linux ELF binary.The package's .targets file used hard-coded
<ItemGroup>blocks that always copiedruntimes/win-x64/native/into every SDK project'sbin/output. SDK-style projects don't need this - NuGet resolves the correctruntimes/{rid}/native/binary automatically at publish time. The forced copy overwrote the correct Linux binary with a Windows one before the publish collector ran.Changes
.targetstwo fixes:<ItemGroup>blocks with a single that prefers$(RuntimeIdentifier)and falls back to aPlatform → RIDmapping.'$(UsingMicrosoftNETSdk)' != 'true'to the<ItemGroup>condition. The manual copy is only needed for legacy .NET Framework consumers; SDK-style projects get native assets resolved automatically, and the copy was actively breaking cross-platform publishing..csproj direct-pack - fix broken paths in the
!$(BuiltOnCI)pack items:Reproduce (Linux / WSL)