This repository was archived by the owner on Feb 27, 2026. It is now read-only.
fix: cordova-ios@8.x compatibility #5
Open
mcastets wants to merge 18 commits into
Open
Conversation
- Preparation for cordova-ios 8.0.0 - Fix some imports
* It could happen, that an undefined background color was set, which lead to a black background. Now nothing will be set on the div Co-authored-by: Manuel Beck <manuelbeck87@outlook.de>
- Removed `document.body.style.transform = 'rotateZ(0deg)';` from Map.js from Map.refreshLayout and Map.setDiv, which was used to for force WebKit browsers to perform a repaint/redraw, because in older WebKit browsers (Safari, early Chrome), certain DOM manipulations or CSS changes wouldn't trigger a visual update immediately, causing rendering glitches or elements appearing "stuck" in their old positions. - This fix is no longer needed in modern WebKit Browsers and caused issues on Chrome on Android, see GitToTheHub#19
….0.0 - @params often declared a wrong parameter - Document the content of the command parameter
…d calling private properties - Since cordova-ios 8 the properties `pluginObjects` and `pluginsMap` in `CDVViewController` are deprecated and should not be used anymore. [CDVViewController registerPlugin:withPluginName:] is used, when `setObject` or `setValue` was called on these deprecated properties before. - Removed deregistering of pseudo map plugins in`pluginUnload` by using private properties `pluginObjects` and `pluginsMap` of `CDVViewController`. There is no equivalent method in `CDVViewController` for deregister a plugin.
…er getCommandInstance:@"CordovaGoogleMaps"]` - Fixes warning: Incompatible pointer types initializing 'CordovaGoogleMaps *' with an expression of type 'CDVPlugin * _Nullable'
…2DInvalid - Check if variable is valid by CLLocationCoordinate2DIsValid()
- Fixes warning: It is unsafe to rely on the MainViewController class as an extension point. Update your code to extend CDVViewController instead. This code will stop working in Cordova iOS 9!
- Fixes deprecation warning of direct property access of webView.scrollView in cordova-ios 8.x. Cordova will remove the scrollView property added as a global category extension to UIView in the future.
- The Crosswalk repository is read-only since April 2020 and not maintanied anymore: https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview
- Set `android-minSdkVersion` by cordova-android
84a6ac8 to
82b8217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.