Fix shared reference issue in traced_points initialization#2426
Open
mathsvisualization wants to merge 1 commit into3b1b:masterfrom
Open
Fix shared reference issue in traced_points initialization#2426mathsvisualization wants to merge 1 commit into3b1b:masterfrom
mathsvisualization wants to merge 1 commit into3b1b:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While using
TracingTail, I observed incorrect trail behavior.The issue was caused by list multiplication during initialization:
This creates multiple references to the same NumPy array instead of independent copies. As a result, updating one point updated all stored points, producing visual artifacts and incorrect tracing behavior.
This PR fixes the issue by ensuring each traced point is an independent copy.
Proposed changes
Before
After
Test
The issue can be reproduced using a simple pendulum example.
Code
Result
Before the fix:
SimplePendulum.mp4
After the fix:
SimplePendulum.mp4