feat(nvapi): implement NvAPI_EnumPhysicalGPUs, NvAPI_EnumLogicalGPUs, NvAPI_GetPhysicalGPUsFromDisplay #120
+40
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquadran
force-pushed
the
nvapi-devices
branch
from
551ad8b to
a88fe4c
Compare
3Shain
requested changes
Feb 2, 2026
aquadran
force-pushed
the
nvapi-devices
branch
from
a88fe4c to
6a516f2
Compare
3Shain
requested changes
Feb 2, 2026
Comment on lines
269
to
277
| auto devices = WMT::CopyAllDevices(); | ||
| auto adapter_count = devices.count(); | ||
| if (adapter_count > 0) { | ||
| *pGpuCount = adapter_count; | ||
| for (unsigned i = 0; i < adapter_count; i++) { | ||
| nvGPUHandle[i] = (NvPhysicalGpuHandle)devices.object(i).registryID(); | ||
| } | ||
| } else { | ||
| return NVAPI_NVIDIA_DEVICE_NOT_FOUND; | ||
| } |
Owner
There was a problem hiding this comment.
nitpick: short-circuit first for better readability
if (adapter_count == 0)
return NVAPI_NVIDIA_DEVICE_NOT_FOUND;
*pGpuCount = adapter_count;
for (unsigned i = 0; i < adapter_count; i++) {
nvGPUHandle[i] = (NvPhysicalGpuHandle)devices.object(i).registryID();
}… NvAPI_GetPhysicalGPUsFromDisplay
aquadran
force-pushed
the
nvapi-devices
branch
from
6a516f2 to
4942c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(nvapi): implement NvAPI_EnumPhysicalGPUs, NvAPI_EnumLogicalGPUs, NvAPI_GetPhysicalGPUsFromDisplay