Changes to streetplan streets label and bus-lane dashed stripe

[atmobi998]

Changes to streetplan streets label and bus-lane dashed stripe

[kfarr]

this appears to combine:

• units behavior
• default striping type for bus/drive lane change for streetplan
• additions to labels to include streetplan specific content

some questions:

• why is the striping change needed? why is it mixed with a pr about labels?
• there is existing work on letting user toggle units (metric / imperial) saved in localstorage (client browser) which is brittle; this pr adds a completely different type of brittleness (global variable during a given session) just adding confusion and chance for error; this units logic does not affect toolbar UI and will confuse users. instead I would suggest that in 3DStreet we have unit type preference set at 2 levels: user preference and scene units type; user default is only for when new scenes are created. a scene setting of units type, if set, will override a user setting; in theory this should be split into a new ticket, but if labels depend on units, which they probably do, then maybe we keep this in. this is challenging but worthy of tackling for everyone's benefit.
• the labels are complicated and beyond my comprehension. some questions. what happens when a user edits the street further in 3dstreet? do the additional label types update? or do they depend on streetplan to generate these? these labels are not very readable on large streets, should we reconsider the camera's default "focus" pose when a user double clicks a street to make it more visible?

[atmobi998]

why is the striping change needed? why is it mixed with a pr about labels?

In streetplan between bus-lane and drive-lane are dashed-stripe, as this picture:
(the change just some lines of codes, do I need to split this to a separated PR?)

there is existing work on letting user toggle units (metric / imperial) saved in localstorage (client browser) which is brittle; this pr adds a completely different type of brittleness (global variable during a given session) just adding confusion and chance for error; this units logic does not affect toolbar UI and will confuse users. instead I would suggest that in 3DStreet we have unit type preference set at 2 levels: user preference and scene units type; user default is only for when new scenes are created. a scene setting of units type, if set, will override a user setting; in theory this should be split into a new ticket, but if labels depend on units, which they probably do, then maybe we keep this in. this is challenging but worthy of tackling for everyone's benefit.

In streetplan, most user's usage scenarios are: user will edit street in streetplan then if they want to show footPrint 3D, they can press 3Dstr button, then they will see/check and close 3D window. So, if any changes to street's objects, that will be started from streetplan.

the labels are complicated and beyond my comprehension. some questions. what happens when a user edits the street further in 3dstreet? do the additional label types update? or do they depend on streetplan to generate these? these labels are not very readable on large streets, should we reconsider the camera's default "focus" pose when a user double clicks a street to make it more visible?

In streetplan, segments are grouped by 2 levels, as following screenshot. The labels in 3D are more simple than streetplan, just keep group level 1 and 2. If SP project owner request, I will add segment info and Cost info to 3D.

the changes to labels look like this:

I think we need focus light to label when user click on the labels band.

The unit display preference should start from streetplan, streetplan users can change to metric unit (MT) like this:

or imperial unit (FT), like this:

I will talk with Mr. Mike to see if he would like to implement 2 ways sync between 3Dstreet and Streetplan on streets edit changes/updates. This would be a great feature!

Please take a look at SP test site:
https://upd.streetplan.net/
or Production site:
https://streetplan.net/

[atmobi998]

this went to 3 PRs, close this now