-
Notifications
You must be signed in to change notification settings - Fork 64
WIP: Start work on integrating the new WordPress Abilities API #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkotter
wants to merge
19
commits into
develop
Choose a base branch
from
try/abilities-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
de84150
Add the Abilities API plugin via composer
dkotter 20116f6
Add a standardized way to register an ability in the base Feature cla…
dkotter 1e7b926
First attempt at register an ability in the Title Generation Feature
dkotter cfb9227
Add a proper execute callback. Change the output schema to support WP…
dkotter 75df803
Add a proper permissions callback. Move the block editor title genera…
dkotter 2ac28f4
Move the classic editor implementation of title generation over to th…
dkotter e770861
Ignore PHPStan error about the wp_register_ability function
dkotter 7d9bd24
Make the ID param required, as we check that in our permission callback
dkotter 762e0d5
Merge branch 'develop' into try/abilities-api
dkotter 3d69326
Ensure the content we return matches the output schema we provide, ot…
dkotter 7291769
Register Image Generation as an ability
dkotter 9fc21ec
Modify Image Providers to support new response structure
dkotter 7dbc05d
Change image generation in the media library to use the new abilities…
dkotter 631fa7c
Ensure image generation works in the media inserter still
dkotter 3aa5fcc
Add a filter around the input schema, allowing each Provider the abil…
dkotter a32dc8b
Remove unused import
dkotter 1b55ed8
Ensure our schema isn't nested
dkotter c677596
Use proper argument name
dkotter 42c01d6
Modify image generation a bit so if we want URLs, instead of base64, …
dkotter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've set this up to match what we already do in this class but wondering if it would be better to have a
method_existscheck here and remove the empty method below?