eth/p2p: raise default tx announcement queue limit from 4096 to 16384#2151
Open
lucca30 wants to merge 2 commits intov2.7.0-candidatefrom
Open
eth/p2p: raise default tx announcement queue limit from 4096 to 16384#2151lucca30 wants to merge 2 commits intov2.7.0-candidatefrom
lucca30 wants to merge 2 commits intov2.7.0-candidatefrom
Conversation
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.77.0 to 1.79.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.77.0...v1.79.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2151 +/- ##
===========================================
+ Coverage 51.51% 51.54% +0.02%
===========================================
Files 882 882
Lines 154140 154140
===========================================
+ Hits 79403 79445 +42
+ Misses 69559 69524 -35
+ Partials 5178 5171 -7
... and 22 files with indirect coverage changes
🚀 New features to boost your workflow:
|
cffls
approved these changes
Mar 23, 2026
Contributor
cffls
left a comment
cffls
left a comment
There was a problem hiding this comment.
There is a version bump in go.mod/sum, maybe due to base branch change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxQueuedTxAnnsfrom 4096 → 16384 ineth/protocols/eth/peer.goTests
TestTxAnnQueueDiscard(eth/protocols/eth/broadcast_test.go): unit test for the discard-oldest semanticsTestTxAnnouncementsAboveOldLimit69/68(eth/handler_eth_test.go): integration test — floods 5000 txs (above old 4096 limit) through a live source→sink peer connection and asserts all arrive without drops