refactor: remove redundant casts

Author: zombyacoff

.github/workflows/ci.yml .github/workflows/ci.yaml.github/workflows/ci.yml renamed to .github/workflows/ci.yaml

@@ -490,10 +490,9 @@ def _deduplicate_collection(
         collection: typing.Union[ItemPage[_T], typing.List[RawAPIItem]],
         /,
     ) -> typing.Union[ItemPage[_T], typing.List[RawAPIItem]]:
-        unique_items = deduplicate_unhashable(collection)
-        if isinstance(collection, ItemPage):
-            return collection.with_items(typing.cast("typing.List[_T]", unique_items))
-        return typing.cast("typing.List[RawAPIItem]", unique_items)
+        if not isinstance(collection, ItemPage):
+            return deduplicate_unhashable(collection)
+        return collection.with_items(deduplicate_unhashable(collection))
 
     @classmethod
     def _create_unix_timestamp_iterator(

.github/workflows/publish.yml .github/workflows/publish.yaml.github/workflows/publish.yml renamed to .github/workflows/publish.yaml

@@ -158,7 +158,7 @@ def _construct_without_metadata(
         cls, items: typing.Optional[typing.Iterable[_R]] = None, /
     ) -> ItemPage[_R]:
         # fmt: off
-        return ItemPage[_R](
+        return cls.model_construct(  # type: ignore[return-value]
             items=tuple(items or ()),
             offset=None, limit=None,
             time_from=None, time_to=None,

src/faceit/api/pagination.py

@@ -195,7 +195,7 @@ def create_uuid_validator(
     error_message: typing.Optional[str] = None,
 ) -> typing.Callable[[typing.Any], str]:
     if error_message is None:
-        error_message = f"Invalid {arg_name}: {{value}}. Expected a valid UUID."
+        error_message = "Invalid {arg_name}: {value}. Expected a valid UUID."
 
     def validator(value: typing.Any, /) -> str:
         if is_valid_uuid(value):

src/faceit/models/item_page.py

@@ -22,7 +22,7 @@
 from faceit.models.custom_types import TimestampMs
 
 if typing.TYPE_CHECKING:
-    from faceit.types import RawAPIItem, RawAPIPageResponse
+    from faceit.types import RawAPIPageResponse
 
 
 class _DummyResource(
@@ -41,9 +41,7 @@ def raw_method(
         offset: int = Field(0, ge=0),
         limit: int = Field(2, ge=1, le=2),
     ) -> RawAPIPageResponse:
-        items = typing.cast(
-            "typing.List[RawAPIItem]", self._items[offset : offset + limit]
-        )
+        items = self._items[offset : offset + limit]
         return {"items": items, "start": offset, "end": offset + limit}
 
     async def async_raw_method(
@@ -67,9 +65,7 @@ def raw_method_with_unix(
             if to is None
             else [item for item in self._items if item["finished_at"] < to]
         )
-        items = typing.cast(
-            "typing.List[RawAPIItem]", filtered[offset : offset + limit]
-        )
+        items = filtered[offset : offset + limit]
         return {"items": items, "start": offset, "end": offset + limit}
 
     async def async_raw_method_with_unix(
@@ -108,22 +104,8 @@ def dummy_resource(
 @pytest.fixture
 def raw_pages() -> typing.Tuple[RawAPIPageResponse, RawAPIPageResponse]:
     return (
-        {
-            "items": [
-                typing.cast("RawAPIItem", {"id": "a"}),
-                typing.cast("RawAPIItem", {"id": "b"}),
-            ],
-            "start": 0,
-            "end": 2,
-        },
-        {
-            "items": [
-                typing.cast("RawAPIItem", {"id": "b"}),
-                typing.cast("RawAPIItem", {"id": "c"}),
-            ],
-            "start": 2,
-            "end": 4,
-        },
+        {"items": [{"id": "a"}, {"id": "b"}], "start": 0, "end": 2},
+        {"items": [{"id": "b"}, {"id": "c"}], "start": 2, "end": 4},
     )
 
 
@@ -177,10 +159,8 @@ def test_extract_unix_timestamp_from_raw_page() -> None:
     second_item_timestamp = 200
     page: RawAPIPageResponse = {
         "items": [
-            typing.cast("RawAPIItem", {"stats": {"Match Finished At": 100}}),
-            typing.cast(
-                "RawAPIItem", {"stats": {"Match Finished At": second_item_timestamp}}
-            ),
+            {"stats": {"Match Finished At": 100}},
+            {"stats": {"Match Finished At": second_item_timestamp}},
         ],
         "start": 0,
         "end": 2,
@@ -280,16 +260,8 @@ def test_sync_iterator_collect_respects_safe_max_items(
 
 async def test_async_gather_from_iterator_raw() -> None:
     async def source() -> typing.AsyncIterator[RawAPIPageResponse]:  # noqa: RUF029
-        yield {
-            "items": [typing.cast("RawAPIItem", {"id": 1})],
-            "start": 0,
-            "end": 1,
-        }
-        yield {
-            "items": [typing.cast("RawAPIItem", {"id": 2})],
-            "start": 1,
-            "end": 2,
-        }
+        yield {"items": [{"id": 1}], "start": 0, "end": 1}
+        yield {"items": [{"id": 2}], "start": 1, "end": 2}
 
     result = await AsyncPageIterator.gather_from_iterator(
         source(),