flight.phases().query('phase == "CLIMB"') returns an error on some flights

[tomschelsen]

Hello (and thank you for this very useful library).

I have a Traffic object containing a bunch of flights, that I created from custom parsed data (not the formats/sources directly supported by the library). I am trying to keep only the climb phases. Inspired by the example here, I'm using this method :

def select_climb():
    for flight in traffic_flights_2:
        if climb := flight.phases().query('phase == "CLIMB"'):
            yield climb

Traffic.from_flights(select_climb())

It works ok on many flights (I had tested .phases().query('phase == "CLIMB"') on a bunch of flights from this dataset and visualised the results beforehand), but it stops on a given flight with this error :

...
Input In [128], in select_climb()
      8 def select_climb():
      9     for flight in traffic_flights_2:
---> 10         if climb := flight.phases().query('phase == "CLIMB"'):
     11             yield climb

File /usr/local/lib/python3.8/dist-packages/traffic/algorithms/phases.py:27, in FuzzyLogic.phases(self, twindow)
     19 fp = FlightPhase()
     20 fp.set_trajectory(
     21     (self.data.timestamp.values - np.datetime64("1970-01-01"))
     22     / np.timedelta64(1, "s"),
   (...)
     25     self.data.vertical_rate.values,
     26 )
---> 27 return self.assign(phase=fp.phaselabel(twindow=twindow)).assign(
     28     phase=lambda df: df.phase.str.replace("GND", "GROUND")
     29     .str.replace("CL", "CLIMB")
     30     .str.replace("DE", "DESCENT")
     31     .str.replace("CR", "CRUISE")
     32     .str.replace("LVL", "LEVEL")
     33 )

File /usr/local/lib/python3.8/dist-packages/traffic/core/mixins.py:218, in DataFrameMixin.assign(self, *args, **kwargs)
    213 def assign(self: T, *args, **kwargs) -> T:
    214     """
    215     Applies the Pandas ``assign()`` method to the underlying pandas
    216     DataFrame and get the result back in the same structure.
    217     """
--> 218     return self.__class__(self.data.assign(*args, **kwargs))

File /usr/local/lib/python3.8/dist-packages/pandas/core/frame.py:4512, in DataFrame.assign(self, **kwargs)
   4509 data = self.copy()
   4511 for k, v in kwargs.items():
-> 4512     data[k] = com.apply_if_callable(v, data)
   4513 return data

File /usr/local/lib/python3.8/dist-packages/pandas/core/frame.py:3655, in DataFrame.__setitem__(self, key, value)
   3652     self._setitem_array([key], value)
   3653 else:
   3654     # set column
-> 3655     self._set_item(key, value)

File /usr/local/lib/python3.8/dist-packages/pandas/core/frame.py:3832, in DataFrame._set_item(self, key, value)
   3822 def _set_item(self, key, value) -> None:
   3823     """
   3824     Add series to DataFrame in specified column.
   3825 
   (...)
   3830     ensure homogeneity.
   3831     """
-> 3832     value = self._sanitize_column(value)
   3834     if (
   3835         key in self.columns
   3836         and value.ndim == 1
   3837         and not is_extension_array_dtype(value)
   3838     ):
   3839         # broadcast across multiple columns if necessary
   3840         if not self.columns.is_unique or isinstance(self.columns, MultiIndex):

File /usr/local/lib/python3.8/dist-packages/pandas/core/frame.py:4535, in DataFrame._sanitize_column(self, value)
   4532     return _reindex_for_setitem(value, self.index)
   4534 if is_list_like(value):
-> 4535     com.require_length_match(value, self.index)
   4536 return sanitize_array(value, self.index, copy=True, allow_2d=True)

File /usr/local/lib/python3.8/dist-packages/pandas/core/common.py:557, in require_length_match(data, index)
    553 """
    554 Check the length of data matches the length of the index.
    555 """
    556 if len(data) != len(index):
--> 557     raise ValueError(
    558         "Length of values "
    559         f"({len(data)}) "
    560         "does not match length of index "
    561         f"({len(index)})"
    562     )

ValueError: Length of values (971) does not match length of index (1182)

Any idea what is happening here, and if the issue comes from the library or my data ? I attach here a subest of the dataset (one flight) for which .phases().query('phase == "CLIMB"') aborts :
problematic_flight_for_phases_climb.csv

Thank you :)

[xoolive]

Thank you for your comment.
Could you please update your library to the latest version of traffic, the file where the error is (phases.py) does not exist anymore 🤷

If the problem persists, please move the discussion into an issue.

[tomschelsen]

Thank you for the quick answer, I updated the library and am still getting the error, filed issue #242, narrowing the problem to phases() (no matter if querying climb or something else I guess) and with an updated traceback.