Skip to content

[RFC]: Replace the snapshot tests with more meaningful code #1154

@KnisterPeter

Description

@KnisterPeter

Reason

Right now the snapshot test does not run on windows, because the path matching in the normalize helper fails to match for windows paths.

The details in the normalizer work on all strings matching a base path. This needs to convert backslashes as well and not only remove the common base path.

Problem

I think a few things about this are awkward:

  1. Replacing strings by regexp in a serialized json object could match other things and not only paths.
  2. Converting all backslashes for 'kind-of'-paths is not that easy and would increase complexity a lot
  3. This is 'patching' the test results before snapshoting them. This means to create code for just the tests to have them more stable which is contraproductive and could lead to fixing the testcode instead of bugs.
  4. Snapshots per se are more useful to detect if something has changed, but unit tests should be there do define whats expected. Right now the expectation in the untool tests with snapshots is not clear.

Solution

  • Rewrite the tests using snapshots into more explicit tests.
  • Maybe convert the tests to jest instead of use ava since the expect output is somewhat better

Additional info

Moved from untool/untool#480

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions