Skip to content

Commit 61ad7a7

Browse files
committed
feat: rename osname and image arch
1 parent 4f963ca commit 61ad7a7

File tree

6 files changed

+23
-14
lines changed

6 files changed

+23
-14
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ native: jni-header snappy-header $(NATIVE_DLL)
151151
native-nocmake: jni-header $(NATIVE_DLL)
152152
snappy: native $(TARGET)/$(snappy-jar-version).jar
153153

154-
native-all: native native-arm clean-docker mac64 win32 win64 linux32 linux64 linux-ppc64le linux-riscv64 linux-s390x alpine-image alpine
154+
native-all: native native-arm clean-docker mac64 win32 win64 linux32 linux64 linux-ppc64le linux-riscv64 linux-s390x musl-image musl
155155

156156
ifdef CI
157157
# Clean docker images within CI to avoid no space left error
@@ -199,11 +199,11 @@ linux32: jni-header
199199
linux64: jni-header
200200
docker run $(DOCKER_RUN_OPTS) -i -v $$PWD:/work xerial/centos5-linux-x86_64-pic bash -c 'make clean-native native-nocmake OS_NAME=Linux OS_ARCH=x86_64'
201201

202-
alpine-image:
203-
docker build -f docker/Dockerfile.linux-x86_64-alpine -t snappy-java-alpine .
202+
musl-image:
203+
docker build -f docker/Dockerfile.linux-x86_64-musl -t snappy-java-musl .
204204

205-
alpine: jni-header
206-
docker run $(DOCKER_RUN_OPTS) -i -v $$PWD:/work snappy-java-alpine bash -c 'make clean-native native-nocmake OS_NAME=Linux OS_ARCH=x86_64-alpine'
205+
musl: jni-header
206+
docker run $(DOCKER_RUN_OPTS) -i -v $$PWD:/work snappy-java-musl bash -c 'make clean-native native-nocmake OS_NAME=Linux OS_ARCH=x86_64-musl'
207207

208208
freebsd64:
209209
$(MAKE) native OS_NAME=FreeBSD OS_ARCH=x86_64

Makefile.common

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ endif
5050
# os=Default is meant to be generic unix/linux
5151

5252
# To support new CPU architecture, add a new target name here
53-
known_os_archs := Linux-x86_64-alpine Linux-x86 Linux-x86_64 Linux-arm Linux-armv6 Linux-armv7 Linux-android-arm Linux-android-aarch64 Linux-aarch64 Linux-ppc Linux-ppc64 Linux-ppc64le Linux-s390 Linux-s390x Mac-x86 Mac-x86_64 Mac-aarch64 FreeBSD-x86_64 Windows-x86 Windows-x86_64 Windows-aarch64 SunOS-x86 SunOS-sparc SunOS-x86_64 AIX-ppc AIX-ppc64 Linux-riscv Linux-riscv64 Linux-loongarch Linux-loongarch64
53+
known_os_archs := Linux-x86_64-musl Linux-x86 Linux-x86_64 Linux-arm Linux-armv6 Linux-armv7 Linux-android-arm Linux-android-aarch64 Linux-aarch64 Linux-ppc Linux-ppc64 Linux-ppc64le Linux-s390 Linux-s390x Mac-x86 Mac-x86_64 Mac-aarch64 FreeBSD-x86_64 Windows-x86 Windows-x86_64 Windows-aarch64 SunOS-x86 SunOS-sparc SunOS-x86_64 AIX-ppc AIX-ppc64 Linux-riscv Linux-riscv64 Linux-loongarch Linux-loongarch64
5454
os_arch := $(OS_NAME)-$(OS_ARCH)
5555
IBM_JDK_7 := $(findstring IBM, $(shell $(JAVA) -version 2>&1 | grep IBM | grep "JRE 1.7"))
5656

@@ -102,16 +102,16 @@ Linux-x86_64_LINKFLAGS := -shared -static-libgcc -static-libstdc++
102102
Linux-x86_64_LIBNAME := libsnappyjava.so
103103
Linux-x86_64_SNAPPY_FLAGS :=
104104

105-
Linux-x86_64-alpine_CXX := $(CROSS_PREFIX)g++
106-
Linux-x86_64-alpine_STRIP := $(CROSS_PREFIX)strip
105+
Linux-x86_64-musl_CXX := $(CROSS_PREFIX)g++
106+
Linux-x86_64-musl_STRIP := $(CROSS_PREFIX)strip
107107
ifeq ($(IBM_JDK_7),)
108-
Linux-x86_64-alpine_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -m64 -std=c++11
108+
Linux-x86_64-musl_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -m64 -std=c++11
109109
else
110-
Linux-x86_64-alpine_CXXFLAGS := -include $(IBM_JDK_LIB)/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -m64 -std=c++11
110+
Linux-x86_64-musl_CXXFLAGS := -include $(IBM_JDK_LIB)/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -O2 -fPIC -fvisibility=hidden -m64 -std=c++11
111111
endif
112-
Linux-x86_64-alpine_LINKFLAGS := -shared -static-libgcc -static-libstdc++
113-
Linux-x86_64-alpine_LIBNAME := libsnappyjava.so
114-
Linux-x86_64-alpine_SNAPPY_FLAGS :=
112+
Linux-x86_64-musl_LINKFLAGS := -shared -static-libgcc -static-libstdc++
113+
Linux-x86_64-musl_LIBNAME := libsnappyjava.so
114+
Linux-x86_64-musl_SNAPPY_FLAGS :=
115115

116116
Linux-ppc_CXX := g++
117117
Linux-ppc_STRIP := strip

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ OsgiKeys.additionalHeaders := Map(
111111
"org/xerial/snappy/native/Linux/ppc64/libsnappyjava.so;osname=linux;processor=ppc64le",
112112
"org/xerial/snappy/native/Linux/s390x/libsnappyjava.so;osname=linux;processor=s390x",
113113
"org/xerial/snappy/native/Linux/loongarch64/libsnappyjava.so;osname=linux;processor=loongarch64",
114-
"org/xerial/snappy/native/Linux/x86_64-alpine/libsnappyjava.so;osname=Linux;processor=x86-64-alpine",
114+
"org/xerial/snappy/native/Linux/x86_64-musl/libsnappyjava.so;osname=Linux;processor=x86-64-musl",
115115
"org/xerial/snappy/native/AIX/ppc/libsnappyjava.a;osname=aix;processor=ppc",
116116
"org/xerial/snappy/native/AIX/ppc64/libsnappyjava.a;osname=aix;processor=ppc64",
117117
"org/xerial/snappy/native/SunOS/x86/libsnappyjava.so;osname=sunos;processor=x86",

src/main/java/org/xerial/snappy/OSInfo.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
package org.xerial.snappy;
2626

2727
import java.io.ByteArrayOutputStream;
28+
import java.io.File;
2829
import java.io.IOException;
2930
import java.io.InputStream;
3031
import java.util.HashMap;
@@ -215,6 +216,10 @@ public static String getArchName() {
215216
return "android-arm";
216217
}
217218

219+
if (isMusl()) {
220+
return "x86_64-musl";
221+
}
222+
218223
if(osArch.startsWith("arm")) {
219224
osArch = resolveArmArchType();
220225
}
@@ -226,6 +231,10 @@ public static String getArchName() {
226231
return translateArchNameToFolderName(osArch);
227232
}
228233

234+
private static boolean isMusl() {
235+
return new File("/lib/ld-musl-x86_64.so.1").exists();
236+
}
237+
229238
static String translateOSNameToFolderName(String osName) {
230239
if(osName.contains("Windows")) {
231240
return "Windows";

src/main/resources/org/xerial/snappy/native/Linux/x86_64-alpine/libsnappyjava.so renamed to src/main/resources/org/xerial/snappy/native/Linux/x86_64-musl/libsnappyjava.so

File renamed without changes.

0 commit comments

Comments
 (0)