Skip to content

Commit 01763ad

Browse files
yedidyakclaude
andcommitted
Address Copilot review: NaN guard, nil sourceView check, explicit import, fetch restore
- extractVersions: validate rnMinor is not NaN before proceeding - RNNCommandsHandler: guard against nil sourceView in preview registration - RNNUIBarButtonItem.h: explicitly import RCTSurfaceDelegate for new arch - Tests: save/restore global.fetch instead of deleting it Co-Authored-By: Claude Opus 4.6 <[email protected]>
1 parent ce43d35 commit 01763ad

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

ios/RNNCommandsHandler.mm

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,9 @@ - (void)push:(NSString *)componentId
212212
view = [[ReactNativeNavigation getBridge].uiManager
213213
viewForReactTag:optionsWithDefault.preview.reactTag.get];
214214
#endif
215+
if (view == nil) {
216+
return;
217+
}
215218
[rootVc registerForPreviewingWithDelegate:(id)rootVc
216219
sourceView:view];
217220
});

ios/RNNUIBarButtonItem.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
#import "RNNIconCreator.h"
33
#import "RNNReactComponentRegistry.h"
44
#import <Foundation/Foundation.h>
5-
#ifndef RCT_NEW_ARCH_ENABLED
5+
#ifdef RCT_NEW_ARCH_ENABLED
6+
#import <React/RCTSurfaceDelegate.h>
7+
#else
68
#import <React/RCTRootView.h>
79
#import <React/RCTRootViewDelegate.h>
810
#endif

scripts/__tests__/changeReactNativeVersion.test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,12 +223,15 @@ describe('changeReactNativeVersion', () => {
223223
});
224224

225225
describe('extractVersions', () => {
226+
let originalFetch;
227+
226228
beforeEach(() => {
229+
originalFetch = global.fetch;
227230
global.fetch = jest.fn();
228231
});
229232

230233
afterEach(() => {
231-
delete global.fetch;
234+
global.fetch = originalFetch;
232235
});
233236

234237
it('extracts versions from npm registry response', async () => {

scripts/changeReactNativeVersion.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ async function extractVersions(rnVersion) {
5151
const reactVersion = String(reactPeer).replace(/^\^/, '');
5252
const rnMinor = parseRnMinor(rnVersion);
5353

54+
if (Number.isNaN(rnMinor)) {
55+
throw new Error(`Could not parse minor version from "${rnVersion}"`);
56+
}
57+
5458
return { rnVersion, reactVersion, rnMinor };
5559
}
5660

0 commit comments

Comments
 (0)