refactor(scripts): Phase 4 — reorganize into functional subdirectories

Scripts categorized into:
  scripts/system/        (health-check, process-monitor-alert, system-monitoring,
                          system-resource-monitor, system-resource-reporter)
  scripts/backup/        (backup, log-file-cleanup, log-rotation, rotate-old-files,
                          rsync-backup, scp-remote-backup)
  scripts/monitoring/    (account-expiry-notify, check-ssl-expiry, disk-usage-monitor,
                          http-status, monitor-open-ports)
  scripts/ci-cd/         (auto-deployment, gc-cleanup, jenkins-job, sonarqube-slack-notify)
  scripts/kubernetes/    (argo-cd-sync, kubectl-namespace-cleanup, scale-deployment)
  scripts/devops/        (docker-log-monitor, git-repo-stats, grafana-metrics,
                          package-updates, splunk-search)
  scripts/notifications/ (create-confluence-page, log-monitor, slack-notify)
  scripts/utils/         (random-password-generator, restart-containers,
                          user-account-management)

Tests mirror the script structure in tests/<category>/.

Changes:
- Updated utils.sh source path: ../lib/utils.sh → ../../lib/utils.sh (wait no)
  actually: ${SCRIPT_DIR}/lib → ${SCRIPT_DIR}/../lib in all 34 scripts
- Updated BATS load paths to use ${BATS_TEST_DIRNAME}/../test_helper/
- Updated BATS SCRIPT_PATH to use ../../scripts/<category>/
- Updated CI to use find-based test discovery (excludes test_helper/)
- Deleted obsolete password-generator.bats (superseded by utils/ version)

Test result: 196/196 pass, exit 0

Author: wesleyscholl

.github/workflows/ci.yml

@@ -41,4 +41,5 @@ jobs:
         run: brew install bats-core
 
       - name: Run BATS test suite
-        run: bats tests/*.bats
+        run: |
+          find tests -name '*.bats' -not -path '*/test_helper/*' | sort | xargs bats

scripts/backup.sh scripts/backup/backup.shscripts/backup.sh renamed to scripts/backup/backup.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 BACKUP_DIR="${BACKUP_DIR:-/var/backups}"
 BACKUP_FILES="${BACKUP_FILES:-/etc /var/www /home /var/lib /var/mail /opt}"

scripts/log-file-cleanup.sh scripts/backup/log-file-cleanup.shscripts/log-file-cleanup.sh renamed to scripts/backup/log-file-cleanup.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 LOG_DIR="${LOG_DIR:-/var/log}"
 MAX_DAYS="${MAX_DAYS:-30}"

scripts/log-rotation.sh scripts/backup/log-rotation.shscripts/log-rotation.sh renamed to scripts/backup/log-rotation.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 LOG_FILE="${LOG_FILE:-/var/log/app.log}"
 MAX_SIZE_MB="${MAX_SIZE_MB:-100}"

scripts/rotate-old-files.sh scripts/backup/rotate-old-files.shscripts/rotate-old-files.sh renamed to scripts/backup/rotate-old-files.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 SOURCE_DIR="${SOURCE_DIR:-/opt/app/data}"
 ARCHIVE_DIR="${ARCHIVE_DIR:-/opt/app/archive}"

scripts/rsync-backup.sh scripts/backup/rsync-backup.shscripts/rsync-backup.sh renamed to scripts/backup/rsync-backup.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 SOURCE_DIR="${SOURCE_DIR:-}"
 REMOTE_DEST="${REMOTE_DEST:-}"

scripts/scp-remote-backup.sh scripts/backup/scp-remote-backup.shscripts/scp-remote-backup.sh renamed to scripts/backup/scp-remote-backup.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 SOURCE_DIR="${SOURCE_DIR:-}"
 REMOTE_HOST="${REMOTE_HOST:-}"

scripts/auto-deployment.sh scripts/ci-cd/auto-deployment.shscripts/auto-deployment.sh renamed to scripts/ci-cd/auto-deployment.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 REPO_DIR="${REPO_DIR:-/path/to/repo}"
 SERVICE="${SERVICE:-myapp}"

scripts/gc-cleanup.sh scripts/ci-cd/gc-cleanup.shscripts/gc-cleanup.sh renamed to scripts/ci-cd/gc-cleanup.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 REPO_DIR="${1:-.}"
 EXPIRY_DAYS=30

scripts/jenkins-job.sh scripts/ci-cd/jenkins-job.shscripts/jenkins-job.sh renamed to scripts/ci-cd/jenkins-job.sh

@@ -4,7 +4,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-source "${SCRIPT_DIR}/lib/utils.sh"
+source "${SCRIPT_DIR}/../lib/utils.sh"
 
 JENKINS_URL="${JENKINS_URL:-http://localhost:8080}"
 JOB_NAME="${JOB_NAME:-}"