Commit df4db9e
committed
Note global-state mutation in three new internal-package test files
The summarizer- and validators-side internal tests added on this branch
swap the package-level log variable (and, for the summarizer handler
test, the summarizerLagEpochs gauge) and restore the originals on
teardown. Add a top-of-file note in each file warning future
contributors not to add t.Parallel() to any test here, since the global
mutation would race across goroutines.
No behavioural change.1 parent 723b098 commit df4db9e
3 files changed
Lines changed: 13 additions & 0 deletions
File tree
- services
- summarizer/standard
- validators/standard
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| |||
0 commit comments