Skip to content

Private Dispose method on Channel #716

@antokhio

Description

@antokhio

I have issue with this line, the problem is this method is hidden:

void IDisposable.Dispose()

I don't understand why this made this way, but if I do:

public class MyCoolChannel<T> : Channel<T>, IDisposable 
{    
   public virtual void Dispose() 
   {
         base.Dispose() // not going to happen
   }
}

Suggest this method should be marked public virtual since right now all the inherited classes should use:

this.AddComponent(IDisposable) 

Instead of implementing IDisposable on them...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions