clippy

Author: sokra

turbopack/crates/turbo-tasks-backend/src/backend/mod.rs

@@ -1639,7 +1639,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
             let mut task = ctx.task(task_id, TaskDataCategory::All);
             if let Some(tasks) = task.prefetch() {
                 drop(task);
-                ctx.prepare_tasks(tasks.into_iter());
+                ctx.prepare_tasks(tasks);
                 task = ctx.task(task_id, TaskDataCategory::All);
             }
             let in_progress = remove!(task, InProgress)?;

turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs

@@ -215,12 +215,11 @@ where
     }
 
     fn get_tx(&self) -> Option<&<B as BackingStorageSealed>::ReadTransaction<'tx>> {
-        let tx = match &self.transaction {
+        match &self.transaction {
             TransactionState::None => unreachable!(),
             TransactionState::Borrowed(tx) => *tx,
             TransactionState::Owned(tx) => tx.as_ref(),
-        };
-        tx
+        }
     }
 
     fn prepare_tasks_with_callback(
@@ -307,7 +306,7 @@ where
                 self.restore_task_data_batch(&tasks_to_restore_for_data, TaskDataCategory::Data)
             {
                 data.into_iter()
-                    .zip(tasks_to_restore_for_data_indicies.into_iter())
+                    .zip(tasks_to_restore_for_data_indicies)
                     .for_each(|(items, idx)| {
                         tasks[idx].2 = Some(items);
                     });
@@ -322,7 +321,7 @@ where
                 self.restore_task_data_batch(&tasks_to_restore_for_meta, TaskDataCategory::Meta)
             {
                 data.into_iter()
-                    .zip(tasks_to_restore_for_meta_indicies.into_iter())
+                    .zip(tasks_to_restore_for_meta_indicies)
                     .for_each(|(items, idx)| {
                         tasks[idx].3 = Some(items);
                     });

turbopack/crates/turbo-tasks-backend/src/kv_backing_storage.rs

@@ -561,7 +561,7 @@ impl<T: KeyValueDatabase + Send + Sync + 'static> BackingStorageSealed
                 },
                 &keys,
             )?;
-            Ok(bytes
+            bytes
                 .into_iter()
                 .map(|opt_bytes| {
                     if let Some(bytes) = opt_bytes {
@@ -571,7 +571,7 @@ impl<T: KeyValueDatabase + Send + Sync + 'static> BackingStorageSealed
                         Ok(Vec::new())
                     }
                 })
-                .collect::<Result<Vec<_>>>()?)
+                .collect::<Result<Vec<_>>>()
         }
         inner
             .with_tx(tx, |tx| lookup(&inner.database, tx, task_ids, category))