Skip to content

Commit 4d0db28

Browse files
committed
include children count in "task execution completed" span
1 parent 630982c commit 4d0db28

File tree

1 file changed

+7
-1
lines changed
  • turbopack/crates/turbo-tasks-backend/src/backend

1 file changed

+7
-1
lines changed

turbopack/crates/turbo-tasks-backend/src/backend/mod.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1773,7 +1773,11 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
17731773
// at the start of every step.
17741774

17751775
#[cfg(not(feature = "trace_task_details"))]
1776-
let _span = tracing::trace_span!("task execution completed").entered();
1776+
let span = tracing::trace_span!(
1777+
"task execution completed",
1778+
new_children = tracing::field::Empty
1779+
)
1780+
.entered();
17771781
#[cfg(feature = "trace_task_details")]
17781782
let span = tracing::trace_span!(
17791783
"task execution completed",
@@ -1782,6 +1786,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
17821786
Ok(value) => display(either::Either::Left(value)),
17831787
Err(err) => display(either::Either::Right(err)),
17841788
},
1789+
new_children = tracing::field::Empty,
17851790
immutable = tracing::field::Empty,
17861791
new_output = tracing::field::Empty,
17871792
output_dependents = tracing::field::Empty,
@@ -1832,6 +1837,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
18321837
}
18331838

18341839
let has_new_children = !new_children.is_empty();
1840+
span.record("new_children", new_children.len());
18351841

18361842
if has_new_children {
18371843
self.task_execution_completed_unfinished_children_dirty(&mut ctx, &new_children)

0 commit comments

Comments
 (0)