Merge pull request avocado-framework#6231 from richtja/pre_commit_hook

Pre commit hook

Author: harvey0100

.github/workflows/ci.yml

@@ -241,8 +241,6 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Run Codespell Check
-        run: make -f Makefile.gh codespell
       - name: Run bandit check
         run: make -f Makefile.gh bandit
         continue-on-error: True

.github/workflows/project.yml

@@ -93,7 +93,7 @@ jobs:
                 projectId: $project
                 itemId: $item
                 fieldId: $status_field
-                value: { 
+                value: {
                   singleSelectOptionId: $status_value
                   }
               }) {

.pre-commit-config.yaml

@@ -0,0 +1 @@
+./static-checks/.pre-commit-config.yaml

.pylintrc

@@ -36,10 +36,6 @@ persistent=yes
 # Specify a configuration file.
 #rcfile=
 
-# When enabled, pylint would attempt to guess common misconfiguration and emit
-# user-friendly hints instead of false-positive error messages.
-suggestion-mode=yes
-
 # Allow loading of arbitrary C extensions. Extensions are imported into the
 # active Python interpreter and may run arbitrary code.
 unsafe-load-any-extension=no
@@ -100,6 +96,7 @@ disable=C0103,
   R0913,
   R0914,
   R0915,
+  R0917,
   R1702,
   R1703,
   R1704,

.pylintrc_utils

@@ -34,10 +34,6 @@ persistent=yes
 # Specify a configuration file.
 #rcfile=
 
-# When enabled, pylint would attempt to guess common misconfiguration and emit
-# user-friendly hints instead of false-positive error messages.
-suggestion-mode=yes
-
 # Allow loading of arbitrary C extensions. Extensions are imported into the
 # active Python interpreter and may run arbitrary code.
 unsafe-load-any-extension=no
@@ -70,6 +66,7 @@ disable=line-too-long,
   useless-suppression,
   use-symbolic-message-instead,
   too-few-public-methods,
+  too-many-positional-arguments,
   fixme
 
 
@@ -504,4 +501,3 @@ accept-no-yields-doc = false
 
 # Possible choices: ['sphinx', 'epytext', 'google', 'numpy', 'default']
 default-docstring-type = sphinx
-

Makefile.gh

@@ -17,10 +17,6 @@ all:
 	@echo "This file contains targets used by GitHub Actions."
 	@echo
 
-codespell:
-	pip install codespell==2.2.4
-	codespell --check-filenames --check-hidden --skip ".git,*.js,./selftests/unit/utils/cpu.py.data/*,./avocado/utils/pmem.py,./avocado/utils/cpu.py,./avocado/utils/linux_modules.py,./selftests/functional/output.py,./selftests/unit/utils/vmimage.py"
-
 bandit:
 	pip install bandit
 	bandit -o bandit-output.txt -r --skip B101,B105,B311,B404,B603 .

avocado-static-checks.conf

@@ -1,4 +1,3 @@
 [lint]
-avocado/utils:static-checks/default_configs/pylintrc
 avocado/utils:.pylintrc_utils
 .:.pylintrc

avocado/core/data_dir.py

@@ -373,6 +373,7 @@ def get_job_results_dir(job_ref, logs_dir=None):
     if len(short_jobid) < 7:
         short_jobid += "*"
     idfile_pattern = os.path.join(logs_dir, f"job-*-{short_jobid}", "id")
+    match_file = None
     for id_file in glob.glob(idfile_pattern):
         with open(id_file, "r", encoding="utf-8") as fid:
             line = fid.read().strip("\n")

avocado/core/nrunner/runner.py

@@ -73,6 +73,7 @@ def running_loop(self, condition):
                           condition for continuing the loop
         """
         most_current_execution_state_time = None
+        next_execution_state_mark = 0
         while not condition():
             now = time.monotonic()
             if most_current_execution_state_time is not None:

avocado/core/status/repo.py

@@ -43,9 +43,9 @@ def _handle_task_finished(self, message):
         if result is not None and result.upper() not in STATUSES:
             overridden = "error"
             message["result"] = overridden
-            message[
-                "fail_reason"
-            ] = f'Runner error occurred: Test reports unsupported status "{result}"'
+            message["fail_reason"] = (
+                f'Runner error occurred: Test reports unsupported status "{result}"'
+            )
             LOG.error(
                 'Task "%s" finished message with unsupported status '
                 '"%s", changing to "%s"',