Adding global node_id and integrating it into the observability package

Author: 0x19

config-peer2.yaml

@@ -1,3 +1,8 @@
+# ======================================================================================
+# NODE IDENTITY RELATED CONFIGURATIONS
+# ======================================================================================
+id: "peer_node_1"
+
 # ======================================================================================
 # LOGGER RELATED CONFIGURATIONS
 # ======================================================================================

config.yaml

@@ -1,3 +1,9 @@
+# ======================================================================================
+# NODE IDENTITY RELATED CONFIGURATIONS
+# ======================================================================================
+id: "bootstrap_node_1"
+
+
 # ======================================================================================
 # LOGGER RELATED CONFIGURATIONS
 # ======================================================================================

pkg/config/config.go

@@ -14,6 +14,9 @@ var global *Config
 // transports, MDBX nodes, and pprof profiling options. This struct aggregates
 // all major configuration sections for easy management and access throughout the application.
 type Config struct {
+	// Id is the unique identifier for the node.
+	Id string `yaml:"id"`
+
 	// Logger holds the configuration for the logging system, including log level and environment.
 	Logger Logger `yaml:"logger"`
 

pkg/observability/metrics.go

@@ -6,6 +6,7 @@ import (
 	"github.com/unpackdev/fdb/pkg/config"
 	"github.com/unpackdev/fdb/pkg/logger"
 	"go.opentelemetry.io/otel"
+	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc"
 	"go.opentelemetry.io/otel/metric"
 	sdkmetric "go.opentelemetry.io/otel/sdk/metric"
@@ -18,7 +19,7 @@ import (
 var ServiceStateCounter metric.Int64Counter
 
 // InitMetrics initializes OpenTelemetry metrics.
-func InitMetrics(ctx context.Context, cfg config.MetricsConfig, logger logger.Logger) (metric.Meter, error) {
+func InitMetrics(ctx context.Context, nodeId string, cfg config.MetricsConfig, logger logger.Logger) (metric.Meter, error) {
 	if !cfg.Enable {
 		return otel.Meter("disabled"), nil
 	}
@@ -37,6 +38,7 @@ func InitMetrics(ctx context.Context, cfg config.MetricsConfig, logger logger.Lo
 	res, err := resource.New(ctx,
 		resource.WithAttributes(
 			semconv.ServiceNameKey.String(ServiceName),
+			attribute.String("node_id", nodeId),
 		),
 	)
 	if err != nil {

pkg/observability/observability.go

@@ -36,7 +36,7 @@ func New(ctx context.Context, cfg config.Config, logger logger.Logger) (*Observa
 	// Initialize Metrics
 	if cfg.Observability.Metrics.Enable {
 
-		obs.Meter, err = InitMetrics(ctx, cfg.Observability.Metrics, logger)
+		obs.Meter, err = InitMetrics(ctx, cfg.Id, cfg.Observability.Metrics, logger)
 		if err != nil {
 			obs.Logger.Error("Failed to initialize metrics", zap.Error(err))
 			return nil, err
@@ -54,7 +54,7 @@ func New(ctx context.Context, cfg config.Config, logger logger.Logger) (*Observa
 
 	// Initialize Tracing
 	if cfg.Observability.Tracing.Enable {
-		obs.Tracer, obs.TracerProvider, err = InitTracer(ctx, cfg.Observability.Tracing, logger)
+		obs.Tracer, obs.TracerProvider, err = InitTracer(ctx, cfg.Id, cfg.Observability.Tracing, logger)
 		if err != nil {
 			obs.Logger.Error("Failed to initialize tracer", zap.Error(err))
 			return nil, err

pkg/observability/traces.go

@@ -7,6 +7,7 @@ import (
 	"github.com/unpackdev/fdb/pkg/logger"
 
 	"go.opentelemetry.io/otel"
+	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
 	"go.opentelemetry.io/otel/sdk/resource"
 	sdktrace "go.opentelemetry.io/otel/sdk/trace"
@@ -16,7 +17,7 @@ import (
 )
 
 // InitTracer initializes OpenTelemetry tracing.
-func InitTracer(ctx context.Context, cfg config.TracingConfig, logger logger.Logger) (trace.Tracer, *sdktrace.TracerProvider, error) {
+func InitTracer(ctx context.Context, nodeId string, cfg config.TracingConfig, logger logger.Logger) (trace.Tracer, *sdktrace.TracerProvider, error) {
 	if !cfg.Enable {
 		return otel.Tracer("disabled"), nil, nil
 	}
@@ -36,6 +37,7 @@ func InitTracer(ctx context.Context, cfg config.TracingConfig, logger logger.Log
 	res, err := resource.New(ctx,
 		resource.WithAttributes(
 			semconv.ServiceNameKey.String(ServiceName),
+			attribute.String("node_id", nodeId),
 		),
 	)
 	if err != nil {

playground/suite/suite.go

@@ -243,6 +243,7 @@ func InitializeNodes(
 
 		// Build the node configuration
 		nodeConfig := config.Config{
+			Id: fmt.Sprintf("playground_node_%d", i),
 			// Logger: config.Logger{
 			// 	Enabled:     true,
 			// 	Environment: "development",