Build is failure on openSUSE Tumbleweed

[hillwoodroc]

[ 93s] computer-view/computer-volume-item.cpp:98:27: error: 'handleVolumeLabelForFat32' is not a member of 'Peony::FileUtils'

[   92s] g++ -c -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DOPENSSL_LOAD_CONF -g -std=gnu++11 -pthread -pthread -pthread -Wall -Wextra -D_REENTRANT -fPIC -DPEONYEXTENSIONCOMPUTERVIEW_LIBRARY -DQT_DEPRECATED_WARNINGS -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQT_NO_KEYWORDS -DQT_PLUGIN -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I. -Icomputer-view -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/peony-qt -I/usr/include/peony-qt/fileop -I/usr/include/peony-qt/model -I/usr/include/qt5/QtWidgets -I/usr/include/qt5 -I/usr/include/qt5/QtCore -I/usr/include/qt5/QtGui -I/usr/include/poppler/qt5 -I/usr/include/poppler -I. -I. -I/usr/lib64/qt5/mkspecs/linux-g++ -o computer-volume-item.o computer-view/computer-volume-item.cpp
[   93s] In file included from computer-view/computer-volume-item.h:26,
[   93s]                  from computer-view/computer-volume-item.cpp:22:
[   93s] computer-view/abstract-computer-item.h: In member function 'virtual void AbstractComputerItem::unmount(GMountUnmountFlags)':
[   93s] computer-view/abstract-computer-item.h:64:45: warning: unused parameter 'unmountFlag' [-Wunused-parameter]
[   93s]    64 |     virtual void unmount(GMountUnmountFlags unmountFlag) {}
[   93s]       |                          ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
[   93s] computer-view/abstract-computer-item.h: In member function 'virtual void AbstractComputerItem::eject(GMountUnmountFlags)':
[   93s] computer-view/abstract-computer-item.h:68:43: warning: unused parameter 'ejectFlag' [-Wunused-parameter]
[   93s]    68 |     virtual void eject(GMountUnmountFlags ejectFlag) {}
[   93s]       |                        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~
[   93s] computer-view/computer-volume-item.cpp: In member function 'void ComputerVolumeItem::updateInfoAsync()':
[   93s] computer-view/computer-volume-item.cpp:98:27: error: 'handleVolumeLabelForFat32' is not a member of 'Peony::FileUtils'
[   93s]    98 |         Peony::FileUtils::handleVolumeLabelForFat32(m_displayName,unixDeviceName);
[   93s]       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~
[   93s] computer-view/computer-volume-item.cpp: In static member function 'static void ComputerVolumeItem::volume_changed_callback(GVolume*, ComputerVolumeItem*)':
[   93s] computer-view/computer-volume-item.cpp:287:59: warning: unused parameter 'volume' [-Wunused-parameter]
[   93s]   287 | void ComputerVolumeItem::volume_changed_callback(GVolume *volume, ComputerVolumeItem *p_this)
[   93s]       |                                                  ~~~~~~~~~^~~~~~
[   93s] computer-view/computer-volume-item.cpp: In static member function 'static void ComputerVolumeItem::volume_removed_callback(GVolume*, ComputerVolumeItem*)':
[   93s] computer-view/computer-volume-item.cpp:299:59: warning: unused parameter 'volume' [-Wunused-parameter]
[   93s]   299 | void ComputerVolumeItem::volume_removed_callback(GVolume *volume, ComputerVolumeItem *p_this)
[   93s]       |                                                  ~~~~~~~~~^~~~~~
[   93s] computer-view/computer-volume-item.cpp: In static member function 'static void ComputerVolumeItem::eject_async_callback(GObject*, GAsyncResult*, ComputerVolumeItem*)':
[   93s] computer-view/computer-volume-item.cpp:409:22: warning: unused variable 'cancelBtn' [-Wunused-variable]
[   93s]   409 |         QPushButton *cancelBtn = (warningBox.addButton(QObject::tr("Cancel"),QMessageBox::RejectRole));
[   93s]       |                      ^~~~~~~~~
[   93s] make[1]: *** [Makefile:599: computer-volume-item.o] Error 1
[   93s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/peony-extensions-3.0.2/peony-extension-computer-view'
[   93s] make: *** [Makefile:114: sub-peony-extension-computer-view-install_subtargets] Error 2
[   93s] error: Bad exit status from /var/tmp/rpm-tmp.j9VDLw (%install)

[brsvh]

It seems something like libpeony-dev or peony-devel is missing, this project is built on the peony development library.
I think you can refer to this experimental rpm description file.

[hillwoodroc]

Comfirmed peony-devel have been installed:

[   15s] [344/353] cumulate peony-3.0.4-11.1
[   15s] [345/353] cumulate rpm-build-4.15.1-8.1
[   15s] [346/353] cumulate libQt5Widgets-devel-5.15.2-1.1
[   15s] [347/353] cumulate libqt5-qtx11extras-devel-5.15.2-1.1
[   15s] [348/353] cumulate libQt5PrintSupport5-5.15.2-1.1
[   15s] [349/353] cumulate libpoppler-devel-20.10.0-1.2
[   15s] [350/353] cumulate libQt5PrintSupport-devel-5.15.2-1.1
[   15s] [351/353] cumulate libpoppler-qt5-devel-20.10.0-1.1
[   15s] [352/353] cumulate libqt5-linguist-5.15.2-1.1
[   15s] [353/353] cumulate peony-devel-3.0.4-11.1
[   15s] now installing cumulated packages
[   16s] Preparing...                          ########################################
[   16s] Updating / installing...
[   16s] system-user-root-20190513-1.21        ########################################
[   16s] filesystem-15.5-35.1                  ########################################
[   16s] glibc-2.32-3.1                        ########################################
[   16s] libz1-1.2.11-18.1                     ########################################

[Yue-Lan]

There was an API changement in libpeony3 ( ukui/peony@252eef1 )

And this function is used in the latest compter view extension. You'd better to make sure building extensions after newest peony-devel installed.

[felixonmars]

@Yue-Lan I have peony 3.1.0 installed, but still cannot build peony-extensions 3.1.0 here:

computer-view-container.cpp:30:10: fatal error: peony-qt/format_dialog.h: No such file or directory
   30 | #include <peony-qt/format_dialog.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~

Apparently that header is not installed by latest peony, even master at the time: https://github.com/ukui/peony/blob/v3.1.0/libpeony-qt/libpeony-qt.pro#L50