Skip to content

Commit f03d048

Browse files
committed
fix(ui5-task-zipper): pin karma's transitive minimatch to keep showcase tests green
Adding minimatch@^10 to ui5-task-zipper caused pnpm to dedup karma@6.4.4's transitive minimatch up from 7.4.9 to 10.2.5. karma calls minimatch as a directly-callable function (mm(path, pattern) in lib/file-list.js), but the callable default export only exists up to v7 — v9+ moved it to the named `minimatch` export. The bump broke the showcase karma tests with 'TypeError: mm is not a function' in the 'build' CI job. Pin karma's transitive minimatch to 7.4.9 (last callable line) via a scoped pnpm override in pnpm-workspace.yaml.
1 parent da06786 commit f03d048

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

pnpm-lock.yaml

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ overrides:
1515
# NOT overridden here: the cross-major bump would force-upgrade
1616
# transitive consumers and is more likely to break than to fix.
1717
"minimatch@<3.1.4": ">=3.1.4"
18+
# karma@6.4.4 calls minimatch as a directly-callable function (mm(path, pattern)
19+
# in lib/file-list.js). That callable default export only exists up to minimatch
20+
# v7; v9+ moved it to the named `minimatch` export, so deduping karma onto a v9/v10
21+
# copy breaks the showcase karma tests with "TypeError: mm is not a function".
22+
# Pin karma's transitive minimatch to the last callable line.
23+
"karma>minimatch": "7.4.9"
1824
"qs@<6.14.1": ">=6.14.1"
1925
"ws@>=8.0.0 <8.20.1": ">=8.20.1"
2026
"tmp@>=0.2.0 <0.2.6": ">=0.2.6"

0 commit comments

Comments
 (0)