Wait for ClickHouse mutations in execute test - #30788
Merged
ebyhr merged 1 commit intoAug 19, 2026
Merged
Conversation
Member
Author
|
@ebyhr test-only wait for async MergeTree mutations in |
Member
Author
|
@cla-bot check |
MergeTree ALTER UPDATE and DELETE are async. Read after system.execute once the mutation is visible.
ebyhr
force-pushed
the
clickhouse-execute-mutation-wait
branch
from
August 19, 2026 00:39
926d5ca to
6480ca7
Compare
ebyhr
approved these changes
Aug 19, 2026
ebyhr
enabled auto-merge
August 19, 2026 00:39
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 19, 2026
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
testExecuteProcedurereads immediately afterCALL system.executeof ClickHouseALTER TABLE ... UPDATEandALTER DELETE. Those MergeTree mutations are asynchronous, so the nextSELECTcan still see the old rows. Wait withassertEventuallyuntil the mutation is visible. The native ALTER SQL is unchanged.Fixes #30787
Additional context and related issues
Showed up on #30744 CI (
plugin/trino-clickhouseon run 32138340060). That PR does not change ClickHouse. This wait is a separate test fix. Reviewer requested: ebyhr.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.