Skip to content

Commit e4b759d

Browse files
committed
Remove release dry run option
1 parent 7410423 commit e4b759d

2 files changed

Lines changed: 13 additions & 20 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ on:
77
description: 'Container registry prefix (e.g., ghcr.io/trinodb)'
88
required: false
99
default: 'ghcr.io/trinodb'
10-
dry_run:
11-
description: 'Dry run (skip git push)'
12-
type: boolean
13-
required: false
14-
default: false
1510

1611
jobs:
1712
prepare:
@@ -35,12 +30,10 @@ jobs:
3530
echo "Error: version file must contain SNAPSHOT version (e.g., 124-SNAPSHOT)"
3631
exit 1
3732
fi
38-
if [ "${{ inputs.dry_run }}" != "true" ]; then
39-
sed -i 's/^\([0-9]\+\)-SNAPSHOT$/\1/' version
40-
VERSION=$(cat version)
41-
git commit -a -m "Release: $VERSION"
42-
git push origin HEAD:master
43-
fi
33+
sed -i 's/^\([0-9]\+\)-SNAPSHOT$/\1/' version
34+
VERSION=$(cat version)
35+
git commit -a -m "Release: $VERSION"
36+
git push origin HEAD:master
4437
echo "COMMIT_SHA=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
4538
4639
release-amd64:
@@ -250,7 +243,6 @@ jobs:
250243
251244
finalize:
252245
needs: [prepare, create-manifests]
253-
if: ${{ inputs.dry_run != true }}
254246
runs-on: ubuntu-24.04
255247
permissions:
256248
contents: write

README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,18 +52,19 @@ multiple artifacts (Docker images) that all need to be released together.
5252

5353
> Note: manual releases are not recommended. Use the GHA Workflow instead.
5454
55-
### Testing Releases (Dry Run)
55+
### Testing the Release Workflow
5656

57-
To test the release process without modifying the official repository:
57+
To test the release workflow without affecting the official repository:
5858

59-
1. Fork this repository
60-
2. Run the `release` workflow with:
61-
- `dry_run: true` - Skips all git commits and tag creation
59+
1. Fork this repository to your personal GitHub account
60+
2. Run the `release` workflow in your fork with:
6261
- `registry: ghcr.io/YOUR_USERNAME` - Pushes images to your personal registry
6362

64-
**Note:** Even in dry run mode, Docker images ARE pushed to the specified registry.
65-
Only git operations (commits, tags) are skipped. This is intended for testing
66-
the full build and push pipeline in a personal fork.
63+
This will perform a full release in your fork, including git commits, tags, and
64+
Docker image pushes. After testing, you may want to manually clean up:
65+
- Delete the release tag from your fork
66+
- Delete the Docker images from your personal registry
67+
- Reset the version file if needed
6768

6869
If you must publish a new version manually, follow these steps:
6970

0 commit comments

Comments
 (0)