Skip to content

Commit 525212f

Browse files
committed
test(webapp): use findFirst over findUnique in triggerTask tests
Repo convention (and CodeRabbit path guideline) is findFirst over findUnique. All are where:{id} lookups, so behaviour is unchanged. Leaves findUniqueOrThrow as-is.
1 parent 6ecce40 commit 525212f

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

apps/webapp/test/engine/triggerTask.idempotency.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ describe("RunEngineTriggerTaskService", () => {
111111
expect(result?.run.status).toBe("PENDING");
112112
expect(result?.isCached).toBe(false);
113113

114-
const run = await prisma.taskRun.findUnique({
114+
const run = await prisma.taskRun.findFirst({
115115
where: {
116116
id: result?.run.id,
117117
},
@@ -315,7 +315,7 @@ describe("RunEngineTriggerTaskService", () => {
315315
expect(result?.run.friendlyId).toBeDefined();
316316
expect(result?.run.status).toBe("PENDING");
317317

318-
const run = await prisma.taskRun.findUnique({
318+
const run = await prisma.taskRun.findFirst({
319319
where: {
320320
id: result?.run.id,
321321
},

apps/webapp/test/engine/triggerTask.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ describe("RunEngineTriggerTaskService", () => {
104104
expect(result?.run.status).toBe("PENDING");
105105
expect(result?.isCached).toBe(false);
106106

107-
const run = await prisma.taskRun.findUnique({
107+
const run = await prisma.taskRun.findFirst({
108108
where: {
109109
id: result?.run.id,
110110
},
@@ -306,7 +306,7 @@ describe("RunEngineTriggerTaskService", () => {
306306
});
307307

308308
expect(result).toBeDefined();
309-
const run = await prisma.taskRun.findUnique({ where: { id: result!.run.id } });
309+
const run = await prisma.taskRun.findFirst({ where: { id: result!.run.id } });
310310
expect(run?.concurrencyKey).toBe("51262");
311311
}
312312
);

0 commit comments

Comments
 (0)