Add confirmation for "Mark all as read"

[danjl1100]

First of all, excellent app! It does exactly what it needs to, and nothing more.

Recently, I had been using the "Earliest unread" menu option to go through the backlog of content I hadn't seen yet. Workflow: just clicking "Earliest unread", laugh, back to overview list, rinse and repeat.

However, by chance I accidentally hit "Mark all as read" instead of "Earliest unread" once, and the game was up.

• Would it be possible to add a confirmation dialog? "All read progress will be lost. Mark all as read?" (or similar)

• Looking at the "Mark all as unread", a similar confirmation dialog could be added to this option too.

I'm running version 8.4.

Let me know how this suggestion sounds to you. I've done a tiny bit of Android development, but it's been a while so I'd need to get up to date for the best way to add this.

Thank you,
Daniel

[tom-anders]

Hi!

Adding this shouldn't be too hard and definitely sounds like a very good idea.

If you want to take a shot at this, here's the line that triggers "mark all as read":

Easy_xkcd/app/src/main/java/de/tap/easy_xkcd/comicOverview/ComicOverviewFragment.kt

Line 275 in 368b988

model.setAllRead(true)

You'll want to add an AlertDialog at this place (take a look at a few lines before this for an example).

Let me know if you need more help or have any questions!

Tom

[danjl1100]

Thank you for the pointer! I'll pick this up (finally found time) and will let you know if I get stuck.

[Wusii]

It just happend to me that I tapped on "delete favorites" (in the overflow menu in the favorites browser), and there too I would have liked a confirmation dialog before all my favorites got deleted. Maybe, this change can be applied there, too..?