Skip to content

bitcoinii-bc2-integration.md

Latest commit

 

History

History
126 lines (104 loc) · 7.76 KB

bitcoinii-bc2-integration.md

File metadata and controls

126 lines (104 loc) · 7.76 KB
Raw

BitcoinII / BC2 BasicSwap Integration

This branch adds initial BasicSwap support for BitcoinII / BC2 as a Bitcoin Core-like SHA-256 PoW chain.

Integration Checklist

BasicSwap's published coin integration guidance says each coin is case-by-case, but the readily integrated path requires:

  • UTXO scripts.
  • CLTV or CSV.
  • Segwit enabled.
  • Watch-only address support.
  • Comparison against similar existing BasicSwap coin integrations.

Source: Particl Academy, "Integrate a Coin", https://academy.particl.io/en/latest/basicswap-guides/basicswapguides_apply.html.

The Academy page notes this requirement list was current for BasicSwap v0.13.4. This branch is based on BasicSwap v0.16.5, so the checklist is treated as the official baseline while the implementation is verified against the current repository patterns.

BitcoinII / BC2 is a Bitcoin Core-derived chain, so this branch follows the existing BTC-like integration pattern used by coins such as Dogecoin and Namecoin: add chain parameters, add a small BTCInterface subclass, wire interface creation and wallet seed checks, add prepare/download/config support, and then validate with daemon and swap tests.

Added

  • Coins.BC2 chain parameters for mainnet, testnet4, and regtest.
  • BitcoinIIInterface, derived from BTCInterface.
  • BasicSwap interface selection, seed ID handling, wallet creation, and daemon argument wiring for BC2.
  • basicswap-prepare support for --withcoins=bitcoinii.
  • BitcoinII v29.1.0 release download and extraction support.
  • Test coverage for BC2 chain parameter lookup and interface coin type.
  • Extended BC2 regtest harness patterned after the existing BTC-like Namecoin tests.

BitcoinII Details Used

  • Coin name: bitcoinii
  • Ticker: BC2
  • Display name: BitcoinII
  • Daemon: bitcoinIId
  • CLI: bitcoinII-cli
  • Mainnet RPC port: 8337
  • Mainnet P2P port: 8338
  • Testnet name: testnet4
  • Testnet RPC port: 48337
  • Regtest RPC port: 18447
  • Message magic: BitcoinII Signed Message:\n

Verified Locally

  • Python syntax checks for changed modules.
  • BC2 chain parameter/interface unit test.
  • basicswap-prepare dry-runs for regtest and testnet with --nocores.
  • BitcoinII v29.1.0 Windows CLI archive download and extraction.
  • bitcoinIId regtest RPC smoke test.
  • Watch-only descriptor import against a private-key-disabled bitcoinIId regtest wallet.
  • Manual requirement probe against bitcoinIId v29.1.0:
    • descriptor RPCs getdescriptorinfo and importdescriptors are available.
    • getdeploymentinfo lists csv, segwit, and taproot.
    • the daemon reports /Satoshi:29.1.0/.
  • Patched BitcoinII Core regtest build from patches/bitcoinii-core-regtest-mining-fix.patch:
    • built bitcoinIId.exe and bitcoinII-cli.exe with wallet support and without GUI/tests/ZMQ.
    • mined three consecutive regtest blocks with generatetoaddress.
    • passed the descriptor/watch-only/mining probe with repeat_mining_ok: true.
    • mined 100 additional blocks and verified the watch wallet saw 150.00000000 trusted mature BC2.
  • Managed regtest setup with Particl plus BC2:
    • downloaded and extracted Particl Core v27.2.3.0.
    • prepared a wallet-initialized --regtest BasicSwap datadir with particl and bitcoinii.
    • created BC2 bsx_wallet and descriptor watch wallet bsx_watch.
    • started full basicswap-run and confirmed the UI returned HTTP 200.
    • confirmed BasicSwap detected BitcoinII Core version 290100.
    • confirmed the BC2 wallet seed check passed without the "not derived from swap seed" warning.
  • Syntax validation for tests/basicswap/extended/test_bitcoinii.py.
  • BC2/PART daemon-backed smoke swap:
    • started local Particl, Bitcoin Core, and patched BitcoinII Core regtest daemons.
    • disabled Monero startup for the smoke run because Windows security blocked monero-wallet-rpc.exe.
    • ran TestBC2.test_02_sh_part_coin.
    • completed the seller-first PART to BC2 swap path successfully.
    • observed both swap clients reach SWAP_COMPLETED.
  • Reverse BC2/PART daemon-backed smoke swap:
    • ran TestBC2.test_03_sh_coin_part.
    • completed the seller-first BC2 to PART swap path successfully.
    • observed both swap clients reach SWAP_COMPLETED.

Roadmap

Done

  • Confirmed the BasicSwap requirement set and matched BC2 against the BTC-like integration path.
  • Added BC2 chain parameters and interface code.
  • Added basicswap-prepare support for BitcoinII v29.1.0 binaries and config generation.
  • Added runtime wiring for daemon arguments, wallet creation, descriptor wallets, and seed checks.
  • Verified project naming uses bitcoinii, BitcoinII, and BC2 consistently.
  • Verified BitcoinII descriptor import into a private-key-disabled watch wallet:
    • createwallet watch disable_private_keys=true blank=true descriptors=true
    • importdescriptors returned success.
    • getaddressinfo on the imported address returned solvable descriptor data.
  • Ran a manual equivalent of the old requirements script as far as the current repo/release allows:
    • UTXO/script behavior follows the Bitcoin Core-derived code path and BTC-like interface.
    • CSV and Segwit are present in getdeploymentinfo.
    • descriptor watch-only wallet RPCs are available and import succeeds.
  • Prepared an initial BitcoinII Core regtest mining patch at patches/bitcoinii-core-regtest-mining-fix.patch.
  • Built the patched BitcoinII Core daemon/CLI locally and verified repeat regtest mining works.
  • Verified funded watch-only balance tracking against the patched regtest daemon.
  • Verified managed Particl plus BC2 regtest startup through BasicSwap's runner.
  • Added tests/basicswap/extended/test_bitcoinii.py, an extended daemon-backed harness for:
    • descriptor spend/watch wallet creation.
    • BC2 wallet initialization from BasicSwap seed material.
    • repeat regtest mining with patched BitcoinII Core.
    • inherited BTC-like script checks for Segwit, CLTV, CSV, watch-only behavior, and related wallet RPCs.
    • seller-first PART/BC2 swap success and refund/error-path coverage through the existing shared BTC-like test helpers.
  • Verified live seller-first PART to BC2 and BC2 to PART smoke swaps with Monero disabled.

Next Verification

  • Run more BC2/PART paths from tests/basicswap/extended/test_bitcoinii.py, especially refund/error paths.
  • Run tests/basicswap/extended/test_bitcoinii.py end-to-end with patched BitcoinII Core binaries and the standard BasicSwap extended-test daemon set available. On this Windows PC the full inherited suite is currently blocked by Windows security blocking monero-wallet-rpc.exe.
  • If the full inherited extended suite is too slow for upstream CI, split out a smaller BC2 smoke test that runs only PART/BC2 seller-first success plus the watch-only/script requirement checks.

Packaging And Upstream Readiness

  • Find or request a signed checksum source for BitcoinII releases. Current prepare support logs the release SHA256 but cannot fully verify it against a signed upstream checksum file.
  • Check whether upstream BasicSwap wants BC2 release downloads from Bitcoin-II/BitcoinII-Core or a separate binary-release repository.
  • Confirm whether upstream BasicSwap wants BC2 covered like Namecoin/Dogecoin in the extended test suite, or whether they prefer a smaller opt-in BC2 smoke test.
  • Decide whether upstream BasicSwap wants BitcoinII as a built-in coin or maintained as a downstream fork.

Local Test Notes

  • The local Particl binary download hash matched the downloaded Particl assert file. Signature verification was skipped for that one local download because Git for Windows gpg.exe was available but failed under the Python/GPG path handling in this environment.
  • The local managed tests use patched BC2 binaries built from patches/bitcoinii-core-regtest-mining-fix.patch; the stock BC2 v29.1.0 release binary still cannot repeatedly mine regtest blocks.