Library does not properly decode dynamic segment from utf-8 route

[estshy]

this.route('worker', {
  path: 'praca-sprzątanie'
}, function () {
  this.route('city', {
    path: 'kczewo'
  });
});

When going on praca-sprzątanie/kczewo, route is properly recognized but dynamic segement is passed down as null. Code does behave correctly with ENCODE_AND_DECODE_PATH_SEGMENTS turned off.

Problem comes down to fact that originalPath is not decoded anyhow but later on it's used inside regular expression.

Is there any way to overwrite ENCODE_AND_DECODE_PATH_SEGMENTS flag from ember application till the issue will be resolved?

Issue was observed on ember 3.4.0

[rwjblue]

@estshy - Can you attempt to submit a failing test case for this? It would almost certainly make fixing much easier...

@bantic - Sorry to pester you here, but I recall you fixing a few related issues here a while back and was wondering if you happen to have a pointer to where to start digging?

[bantic]

@rwjblue No worries, thanks for the ping. I'll take a look at this and give some ideas.

[bantic]

@estshy Can you give some more details to help reproduce the issue you're seeing?

this.route('worker', {
  path: 'praca-sprzątanie'
}, function () {
  this.route('city', {
    path: 'kczewo'
  });
});

This router snippet that you provided above doesn't have any dynamic segments. It instructs the router to recognize the static path "/praca-sprzątanie/kczewo".
This static path seems to work fine. Here's a Twiddle that shows it working. Clicking the link (or pasting in the path directly to the twiddle's address bar) correctly takes you to the worker/city route and displays the template.

I created a second twiddle that has a dynamic segment for worker and city. It also appears to recognize your path ok. Clicking the link (or pasting path in directly) takes you to the worker/city route with the worker and city dynamic segments properly populated.

Let me know if I misunderstood the issue that you ran into.

[estshy]

@bantic At the moment I am not able to reproduce the issue on twiddle and I am not sure why. I will get back to you with a failing test case when I will have more time to dig into it. For now I made workaround by extracting the missing parameter from url manually.

[KoKuToru]

well not sure if this is still the correct place for current ember..

but I have the same problem

here is a test case, just a modified version of "A dynamic route recognizes"

for recognizer-test.ts:

QUnit.test("A dynamic route recognizes UTF8", (assert: Assert) => {
  const handler = {};
  const router = new RouteRecognizer<{}>();
  router.add([{ path: "/bär/:foo", handler }]);
  router.add([{ path: "/:foo/bär", handler }]);

  resultsMatch(assert, router.recognize("/1/b%C3%A4r"), [
    { handler: handler, params: { foo: "1" }, isDynamic: true }
  ])
  resultsMatch(assert, router.recognize("/b%C3%A4r/1"), [
    { handler: handler, params: { foo: "1" }, isDynamic: true }
  ])
}

it wont recognize /1/b%C3%A4r or /b%C3%A4r/1 but will work for /1/bär and /bär/1