Commit 6d86adc
committed
fix(build): make version-bump portable and bump the lock file too
Two problems, both found by trying to run it.
`sed -i "s/..."` is GNU-only. BSD sed, which is what macOS ships, reads the next
argument as the backup suffix, so it consumed the expression and then treated the
filename as the script:
sed: 1: "indexer/chart/Chart.yaml": unescaped newline inside substitute pattern
`sed -i.bak ... && rm -f ...bak` works on both, so the target now runs anywhere
rather than only on Linux.
It also never touched package-lock.json, so the lock file kept the previous
version while package.json moved on — 2.12.3 against 2.13.0 after this bump, and
drifting a little further every release. `npm ci` tolerates it, because it only
validates dependency resolution and not the root package's own version, which is
why nothing has complained so far. Now bumped alongside package.json, both the
top-level version and packages[""].version, in the same jq style the target
already used.
Behaviour is otherwise unchanged, and deliberately still local only: it creates a
branch and a commit and never pushes.1 parent b81efc3 commit 6d86adc
1 file changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
6 | 9 | | |
7 | 10 | | |
8 | 11 | | |
| |||
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
16 | | - | |
17 | | - | |
18 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
| |||
0 commit comments