Merge pull request #396 from thoughtspot/SCAL-290499

shivam-kumar-ts · web-flow · commit 9c35ab7a2fb6 · 2026-01-13T11:10:20.000+05:30
SCAL-290499 Update URL handling to preserve subsection hashes in iframe
diff --git a/src/components/DevDocTemplate/index.tsx b/src/components/DevDocTemplate/index.tsx
@@ -251,6 +251,10 @@ const DevDocTemplate: FC<DevDocTemplateProps> = (props) => {
                     }
 
                     url.searchParams.set('pageid', e.data.params.pageid);
+                    const hash = e.data.subsection;
+                    if (hash) {
+                        url.hash = hash;
+                    }
                     window.history.replaceState({}, '', url.toString());
                 }
             }
diff --git a/src/components/VersionIframe/index.tsx b/src/components/VersionIframe/index.tsx
@@ -34,11 +34,14 @@ const VersionIframe: React.FC<VersionIframeProps> = ({
             } else if (mainUrlParams.has('pageId')) {
                 url.searchParams.set('pageid', mainUrlParams.get('pageId'));
             }
+            if (location?.hash) {
+                url.hash = location?.hash;
+            }
             url.searchParams.set('_iframe', '1');
         }
 
         return url.toString();
-    }, [iframeUrl, isDarkMode, location?.search]);
+    }, [iframeUrl, isDarkMode, location?.search, location?.hash]);
 
     return (
         <div className="version-iframe-container">

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,10 @@ const DevDocTemplate: FC<DevDocTemplateProps> = (props) => {`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`url.searchParams.set('pageid', e.data.params.pageid);`
	`254`	`+ const hash = e.data.subsection;`
	`255`	`+ if (hash) {`
	`256`	`+ url.hash = hash;`
	`257`	`+ }`
`254`	`258`	`window.history.replaceState({}, '', url.toString());`
`255`	`259`	`}`
`256`	`260`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,14 @@ const VersionIframe: React.FC<VersionIframeProps> = ({`
`34`	`34`	`} else if (mainUrlParams.has('pageId')) {`
`35`	`35`	`url.searchParams.set('pageid', mainUrlParams.get('pageId'));`
`36`	`36`	`}`
	`37`	`+ if (location?.hash) {`
	`38`	`+ url.hash = location?.hash;`
	`39`	`+ }`
`37`	`40`	`url.searchParams.set('_iframe', '1');`
`38`	`41`	`}`
`39`	`42`
`40`	`43`	`return url.toString();`
`41`		`- }, [iframeUrl, isDarkMode, location?.search]);`
	`44`	`+ }, [iframeUrl, isDarkMode, location?.search, location?.hash]);`
`42`	`45`
`43`	`46`	`return (`
`44`	`47`	`<div className="version-iframe-container">`