remove redundant commands

Author: Kamix-08

README.md

@@ -62,12 +62,9 @@ Show Spotify Lyrics via Spotilyrics
 - `Logout from Spotilyrics` (`spotilyrics.logout`) – clear session and re-auth when needed.
 - `Set Tracks Cache Max Size` (`spotilyrics.setTracksCacheMaxSize`) – configure the maximum number of tracks cached for lyrics.
 - `Set Spotify OAuth Callback Port` (`spotilyrics.setPort`) – set the local callback port used for Spotify OAuth.
-- `Set Hide Song Title` (`spotilyrics.setHideSongTitle`) – set hiding the song title in the lyrics panel.
-- `Set Hide Song Icon` (`spotilyrics.setHideSongIcon`) – set hiding the song icon in the lyrics panel.
-- `Set Hide Song Author` (`spotilyrics.setHideSongAuthor`) – set hiding the song author in the panel title.
-- `Toggle Hide Song Title` (`spotilyrics.toggleHideSongTitle`) – toggle hiding the song title in the lyrics panel.
-- `Toggle Hide Song Icon` (`spotilyrics.toggleHideSongIcon`) – toggle hiding the song icon in the lyrics panel.
-- `Toggle Hide Song Author` (`spotilyrics.toggleHideSongAuthor`) – toggle hiding the song author in the panel title.
+- `Hide Song Title` (`spotilyrics.hideSongTitle`) – toggle the song title in the lyrics panel.
+- `Hide Song Icon` (`spotilyrics.hideSongIcon`) – toggle the song icon in the lyrics panel.
+- `Hide Song Artist` (`spotilyrics.hideSongArtist`) – toggle the song artist in the panel title.
 
 ---
 

package.json

@@ -56,10 +56,10 @@
                     "default": false,
                     "description": "Don't show the album icon on the panel card."
                 },
-                "spotilyrics.hideSongAuthor": {
+                "spotilyrics.hideSongArtist": {
                     "type": "boolean",
                     "default": false,
-                    "description": "Don't show the song author in the panel title."
+                    "description": "Don't show the song artist in the panel title."
                 }
             }
         },
@@ -85,36 +85,16 @@
                 "title": "Set Spotify OAuth Callback Port"
             },
             {
-                "command": "spotilyrics.setHideSongTitle",
-                "title": "Set Hide Song Title"
+                "command": "spotilyrics.hideSongTitle",
+                "title": "Hide Song Title"
             },
             {
-                "command": "spotilyrics.setHideSongIcon",
-                "title": "Set Hide Song Icon"
+                "command": "spotilyrics.hideSongIcon",
+                "title": "Hide Song Icon"
             },
             {
-                "command": "spotilyrics.setHideSongAuthor",
-                "title": "Set Hide Song Author"
-            },
-            {
-                "command": "spotilyrics.toggleHideSongTitle",
-                "title": "Toggle Hide Song Title"
-            },
-            {
-                "command": "spotilyrics.toggleHideSongIcon",
-                "title": "Toggle Hide Song Icon"
-            },
-            {
-                "command": "spotilyrics.setHideSongAuthor",
-                "title": "Set Hide Song Author"
-            },
-            {
-                "command": "spotilyrics.toggleHideSongAuthor",
-                "title": "Toggle Hide Song Author"
-            },
-            {
-                "command": "spotilyrics.toggleHideSongAuthor",
-                "title": "Toggle Hide Song Author"
+                "command": "spotilyrics.hideSongArtist",
+                "title": "Hide Song Artist"
             }
         ]
     },

src/extension.ts

@@ -221,58 +221,7 @@ export async function activate(context: vscode.ExtensionContext) {
     );
 
     context.subscriptions.push(
-        vscode.commands.registerCommand('spotilyrics.setHideSongTitle', async () => {
-            const config = vscode.workspace.getConfiguration('spotilyrics');
-            const input = await vscode.window.showQuickPick(['hide', 'show'], {
-                canPickMany: false,
-            });
-
-            if (!input) {
-                return;
-            }
-            const value = input == 'hide';
-            await config.update('hideSongTitle', value, vscode.ConfigurationTarget.Global);
-            vscode.window.showInformationMessage(
-                `Song title has been ${value ? 'hidden' : 'shown'}`
-            );
-        })
-    );
-    context.subscriptions.push(
-        vscode.commands.registerCommand('spotilyrics.setHideSongIcon', async () => {
-            const config = vscode.workspace.getConfiguration('spotilyrics');
-            const input = await vscode.window.showQuickPick(['hide', 'show'], {
-                canPickMany: false,
-            });
-
-            if (!input) {
-                return;
-            }
-            const value = input == 'hide';
-            await config.update('hideSongIcon', value, vscode.ConfigurationTarget.Global);
-            vscode.window.showInformationMessage(
-                `Song icon has been ${value ? 'hidden' : 'shown'}`
-            );
-        })
-    );
-    context.subscriptions.push(
-        vscode.commands.registerCommand('spotilyrics.setHideSongAuthor', async () => {
-            const config = vscode.workspace.getConfiguration('spotilyrics');
-            const input = await vscode.window.showQuickPick(['hide', 'show'], {
-                canPickMany: false,
-            });
-
-            if (!input) {
-                return;
-            }
-            const value = input == 'hide';
-            await config.update('hideSongAuthor', value, vscode.ConfigurationTarget.Global);
-            vscode.window.showInformationMessage(
-                `Song author has been ${value ? 'hidden' : 'shown'}`
-            );
-        })
-    );
-    context.subscriptions.push(
-        vscode.commands.registerCommand('spotilyrics.toggleHideSongTitle', async () => {
+        vscode.commands.registerCommand('spotilyrics.hideSongTitle', async () => {
             const config = vscode.workspace.getConfiguration('spotilyrics');
             const value = !config.get('hideSongTitle');
             await config.update('hideSongTitle', value, vscode.ConfigurationTarget.Global);
@@ -282,7 +231,7 @@ export async function activate(context: vscode.ExtensionContext) {
         })
     );
     context.subscriptions.push(
-        vscode.commands.registerCommand('spotilyrics.toggleHideSongIcon', async () => {
+        vscode.commands.registerCommand('spotilyrics.hideSongIcon', async () => {
             const config = vscode.workspace.getConfiguration('spotilyrics');
             const value = !config.get('hideSongIcon');
             await config.update('hideSongIcon', value, vscode.ConfigurationTarget.Global);
@@ -292,12 +241,12 @@ export async function activate(context: vscode.ExtensionContext) {
         })
     );
     context.subscriptions.push(
-        vscode.commands.registerCommand('spotilyrics.toggleHideSongAuthor', async () => {
+        vscode.commands.registerCommand('spotilyrics.hideSongArtist', async () => {
             const config = vscode.workspace.getConfiguration('spotilyrics');
-            const value = !config.get('hideSongAuthor');
-            await config.update('hideSongAuthor', value, vscode.ConfigurationTarget.Global);
+            const value = !config.get('hideSongArtist');
+            await config.update('hideSongArtist', value, vscode.ConfigurationTarget.Global);
             vscode.window.showInformationMessage(
-                `Song author has been ${value ? 'hidden' : 'shown'}`
+                `Song artist has been ${value ? 'hidden' : 'shown'}`
             );
         })
     );
@@ -465,14 +414,14 @@ function updatePanelMeta(
         return;
     }
 
-    const showTitle = !vscode.workspace.getConfiguration('spotilyrics').get('hideSongTitle');
-    const showAuthor = !vscode.workspace.getConfiguration('spotilyrics').get('hideSongAuthor');
+    const hideTitle = vscode.workspace.getConfiguration('spotilyrics').get('hideSongTitle');
+    const hideArtist = vscode.workspace.getConfiguration('spotilyrics').get('hideSongArtist');
 
-    if (!showTitle && !showAuthor) {
+    if (hideTitle && hideArtist) {
         panel.title = 'Spotify Lyrics';
-    } else if (showTitle && !showAuthor) {
+    } else if (!hideTitle && hideArtist) {
         panel.title = trackName;
-    } else if (showAuthor && !showTitle) {
+    } else if (!hideArtist && hideTitle) {
         panel.title = artistName;
     } else {
         panel.title = `${artistName} - ${trackName}`;
@@ -513,9 +462,6 @@ async function updateLyrics(context: vscode.ExtensionContext) {
             albumImages[albumImages.length - 1].url
         );
 
-        for (const artist of currentlyPlayingResponse.item.artists) {
-            artistNames.push(artist.name);
-        }
         const artists: string = artistNames.join(' ');
         if (
             !currentPlayingState ||