Skip to content

Rework Subscription creation #23

@themightyoarfish

Description

@themightyoarfish

Right now, the leaf subscriber classes accept a kinds parameter and use that to create a Subscription object to pass to the superclass initialiser.

It is weird that the base class initialiser's parameters are not a proper subset of the inheriting classes' initialisers.

Proposed Solution

  1. accept kinds, tag, and subsample parameters in base Subscriber initialiser, and instantiate Subscription there.
  2. … not sure what else

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions