Fix eslint patterns. (#1067)

Closes the-draupnir-project/planning#110

Author: Gnuxie

apps/draupnir/src/appservice/AppServiceDraupnirManager.ts

@@ -477,15 +477,15 @@ export async function makeManagementRoom(
       "Failed to fetch room versions from client capabilities"
     );
   }
-  const isRoomVersionWithPrivilidgedCreators =
+  const isRoomVersionWithPriviligedCreators =
     RoomVersionMirror.isVersionWithPrivilegedCreators(
       capabilities.ok.capabilities["m.room_versions"].default
     );
   return await roomCreator.createRoom({
     preset: "private_chat",
     invite: [requestingUserID],
     name: `${requestingUserID}'s Draupnir`,
-    power_level_content_override: isRoomVersionWithPrivilidgedCreators
+    power_level_content_override: isRoomVersionWithPriviligedCreators
       ? {
           users: {
             [requestingUserID]: 150,

apps/draupnir/src/commands/ProtectionsCommands.tsx

@@ -400,7 +400,7 @@ async function findSettingDetailsForCommand(
   if (isError(protectionDescription)) {
     return protectionDescription;
   }
-  const settingsDescription = protectionDescription.ok.protectionSettings;
+  type SettingsDescription = typeof protectionDescription.ok.protectionSettings;
   const previousSettings = await protectionsManager.getProtectionSettings(
     protectionDescription.ok
   );
@@ -410,7 +410,7 @@ async function findSettingDetailsForCommand(
   return Ok({
     protectionDescription: protectionDescription.ok,
     propertyKey:
-      settingName as keyof typeof settingsDescription.schema.properties,
+      settingName as keyof SettingsDescription["schema"]["properties"],
     description: protectionDescription.ok.protectionSettings,
     previousSettings: previousSettings.ok,
   });

apps/draupnir/src/protections/BanPropagation.tsx

@@ -211,8 +211,13 @@ export class BanPropagationProtection
   extends AbstractProtection<BanPropagationProtectionCapabilitiesDescription>
   implements DraupnirProtection<BanPropagationProtectionCapabilitiesDescription>
 {
-  private readonly banPropagationPromptListener =
-    this.banReactionListener.bind(this);
+  private readonly banPropagationPromptListener = (
+    key: string,
+    item: unknown,
+    context: BanPropagationMessageContext
+  ) => {
+    void Task(this.banReactionListener(key, item, context), { log });
+  };
   constructor(
     description: BanPropagationProtectionCapabilitiesDescription,
     lifetime: OwnLifetime<

apps/draupnir/src/protections/DraupnirNews/DraupnirNews.tsx

@@ -127,7 +127,7 @@ export class DraupnirNewsLifecycle {
 const FSNews = (() => {
   const content = JSON.parse(
     readFileSync(path.join(__dirname, "./news.json"), "utf8")
-  );
+  ) as unknown;
   return Value.Decode(DraupnirNewsBlob, content).expect(
     "File system news should match the schema"
   );
@@ -144,7 +144,7 @@ async function fetchNews(newsURL: string): Promise<Result<DraupnirNewsBlob>> {
     .then((response) => response.json())
     .then(
       (json) => Value.Decode(DraupnirNewsBlob, json),
-      (error) =>
+      (error: unknown) =>
         ActionException.Result("unable to fetch news", {
           exception: error,
           exceptionKind: ActionExceptionKind.Unknown,

apps/draupnir/src/protections/ProtectedRooms/WatchReplacementPolicyRooms.tsx

@@ -40,6 +40,7 @@ import {
   renderMentionPill,
   sendMatrixEventsFromDeadDocument,
   renderErrorDetails,
+  ReactionListener,
 } from "@the-draupnir-project/mps-interface-adaptor";
 import { RoomReactionSender } from "matrix-protection-suite/dist/Client/RoomReactionSender";
 
@@ -195,8 +196,13 @@ async function sendPromptForReplacementRoom(
  * - `syncTombstonedPolicyRooms` must be called if you want it to detect stale tombstones at startup.
  */
 export class WatchReplacementPolicyRooms {
-  private readonly watchReplacementPolicyRoomsPromptListener =
-    this.handlePromptReaction.bind(this);
+  private readonly watchReplacementPolicyRoomsPromptListener = (
+    ...args: Parameters<ReactionListener<WatchPolicyRoomPromptContext>>
+  ) => {
+    void Task(this.handlePromptReaction(...args), {
+      log,
+    });
+  };
   public constructor(
     private readonly managementRoomID: StringRoomID,
     private readonly roomJoiner: RoomJoiner,

apps/draupnir/src/safemode/PersistentConfigRenderer.tsx

@@ -78,8 +78,10 @@ function renderConfigPropertyValue(value: unknown): DocumentNode {
       return <ul>{value.map((value) => renderConfigPropertyValue(value))}</ul>;
     } else {
       return (
+        // FIXME: We should probably try walk this but ya.
+        // We don't have time for that and no one uses objects here yet.
         <fragment>
-          <code>{String(value)}</code>{" "}
+          <code>{"[object Object]"}</code>{" "}
           <span data-mx-color="#D2691E">(object)</span>
         </fragment>
       );

package.json

@@ -21,7 +21,7 @@
     "build:all": "tsc -b tsconfig.all.json && npm run -ws build:assets --if-present",
     "build:clean": "tsc -b --clean",
     "test": "npm run -ws test --if-present && npm run -w apps/draupnir test:unit",
-    "lint": "eslint --cache 'packages/**/*{ts, tsx}' 'apps/**/*{ts, tsx}' && prettier --cache --ignore-unknown --check apps packages README.md CHANGELOG.md DEPENDENCIES.md"
+    "lint": "eslint --cache 'packages/**/*.{ts,tsx}' 'apps/**/*.{ts,tsx}' && prettier --cache --ignore-unknown --check apps packages README.md CHANGELOG.md DEPENDENCIES.md"
   },
   "devDependencies": {
     "@changesets/cli": "^2.30.0",

packages/mps-interface-adaptor/src/MPSInterfaceAdaptor/MatrixReactionHandler.ts

@@ -36,10 +36,10 @@ type ItemByReactionKey = Map<
   string /*reaction key*/,
   string /*serialized presentation*/
 >;
-export type ReactionListener = (
+export type ReactionListener<Context = unknown> = (
   key: string,
   item: string,
-  additionalContext: unknown,
+  additionalContext: Context,
   reactionMap: ItemByReactionKey,
   annotatedEvent: RoomEvent
 ) => void;