Skip to content

Commit 17105ed

Browse files
committed
Further lessen code complexity
1 parent 7a0ee92 commit 17105ed

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

app/controllers/api/v8/users_controller.rb

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -172,24 +172,21 @@ def update
172172

173173
def set_password_managed_by_moocfi
174174
unauthorize_guest! if current_user.guest?
175-
176175
@user = User.find_by!(id: params[:id])
177176
authorize! :update, @user
178177

179178
value = params[:set_password_managed_by_moocfi]
180-
if !boolean_param?(value)
179+
unless boolean_param?(value)
181180
@user.errors.add(:password_managed_by_moocfi, 'must be a boolean')
182-
else
183-
@user.password_managed_by_moocfi = value
181+
return render json: { errors: @user.errors }, status: :bad_request
184182
end
185183

186-
if @user.errors.any? || !@user.save
187-
render json: { errors: @user.errors }, status: :bad_request
188-
else
189-
render json: {
190-
status: "Password managed by Mooc.fi set to #{value}."
191-
}
192-
end
184+
@user.password_managed_by_moocfi = value
185+
return render json: { errors: @user.errors }, status: :bad_request unless @user.save
186+
187+
render json: {
188+
status: "Password managed by Mooc.fi set to #{value}."
189+
}
193190
end
194191

195192
private

0 commit comments

Comments
 (0)