Skip to content

[Bug]: custom variant paintings break #149

Description

@deli73

Bug Description

When using commands to update a fancy painting entity's "variant" property, the painting always breaks, even if it fits in the space. My only guess at the cause is the final condition in HangingEntity.survives(), as maybe the painting somehow doesn't recognize itself as not a distinct entity taking up its space?

How to Reproduce?

  1. Place a fancy painting.
  2. Use the command `/data merge (entity UUID) {variant:"(custom painting variant (in the handcrafted namespace) with the same size)"}
  3. Observe the painting update to another painting, and then mysteriously pop off as if it's been obstructed.

Expected Behavior

Painting should remain in place as nothing is obstructing it.

Version

4.0.3

Mod Loader Version

1.21.1 - 0.16.14

Mod Loader

Fabric

Logs or additional context

No response

Code of Conduct

  • I have searched the issue tracker and confirmed that the issue has not been reported
  • I have checked the FAQ (if one is present) and my issue is not listed
  • I have verified that I am using the latest version of the mod
  • I have verified that I have installed all the required dependencies for the mod
  • I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions