Skip to content

Commit cc9dc89

Browse files
authored
Allow embedding Perfetto UI in Tensorboard pages (#7048)
## Motivation for features / changes This is a required step for open sourcing the new Megascale Perfetto tool in xprof. Googlers see b/476134328 ## Technical description of changes Adds https://ui.perfetto.dev to the whitelist of domains that are allowed to be embedded in a frame on the page. A follow up change will embed this UI in the xprof (Profiler) plugin. ## Screenshots of UI changes (or N/A) N/A ## Detailed steps to verify changes work correctly (as executed by you) Tested on Tensorboard (in combination with other necessary changes) and verified that it works as expected. ## Alternate designs / implementations considered (or N/A) N/A
1 parent 0743619 commit cc9dc89

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tensorboard/backend/http_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
# @vaadin/vaadin-lumo-styles/font-icons(via vaadin-grid) uses data URI for
3737
# loading font icons.
3838
_CSP_FONT_DOMAINS_WHITELIST = ["data:"]
39-
_CSP_FRAME_DOMAINS_WHITELIST = []
39+
_CSP_FRAME_DOMAINS_WHITELIST = ["https://ui.perfetto.dev"]
4040
_CSP_IMG_DOMAINS_WHITELIST = []
4141
_CSP_SCRIPT_DOMAINS_WHITELIST = []
4242
_CSP_CONNECT_DOMAINS_WHITELIST = []

0 commit comments

Comments
 (0)