fix: include schema in TVP type declaration (#1730)

Author: dhensby

src/data-types/tvp.ts

@@ -14,7 +14,8 @@ const TVP: DataType = {
 
   declaration: function(parameter) {
     const value = parameter.value as any; // Temporary solution. Remove 'any' later.
-    return value.name + ' readonly';
+    const schema = value.schema ? value.schema + '.' : '';
+    return schema + value.name + ' readonly';
   },
 
   generateTypeInfo(parameter) {

test/unit/data-type.ts

@@ -1384,6 +1384,36 @@ describe('TinyInt', function() {
 });
 
 describe('TVP', function() {
+  describe('.declaration', function() {
+    it('returns type name with readonly', function() {
+      const result = TYPES.TVP.declaration({
+        value: { name: 'MyTableType', schema: '', columns: [], rows: [] }
+      } as any);
+      assert.strictEqual(result, 'MyTableType readonly');
+    });
+
+    it('includes schema when present', function() {
+      const result = TYPES.TVP.declaration({
+        value: { name: 'UDT_StringArray', schema: 'AI', columns: [], rows: [] }
+      } as any);
+      assert.strictEqual(result, 'AI.UDT_StringArray readonly');
+    });
+
+    it('works with null schema', function() {
+      const result = TYPES.TVP.declaration({
+        value: { name: 'MyTableType', schema: null, columns: [], rows: [] }
+      } as any);
+      assert.strictEqual(result, 'MyTableType readonly');
+    });
+
+    it('works with undefined schema', function() {
+      const result = TYPES.TVP.declaration({
+        value: { name: 'MyTableType', columns: [], rows: [] }
+      } as any);
+      assert.strictEqual(result, 'MyTableType readonly');
+    });
+  });
+
   describe('.generateParameterLength', function() {
     it('returns the correct data length', function() {
       assert.deepEqual(TYPES.TVP.generateParameterLength({ value: null }, options), Buffer.from([0xFF, 0xFF]));