Skip to content

Person.tags doesn't always return a Highrise::Tag array #57

@basvodde

Description

@basvodde

The current tags implementation (in taggable) uses get(:tags) which returns a Hash and not a Highrise::Tag. This causes trouble when adding tags and retrieving them later.

There are probably two solutions:

  1. Pass the Hash to a create of the Highrise::Tag and return that (ugly)
  2. Do a find instead of a get, so that the Hash gets recordized.

Other ideas welcome :) Fixed it locally but it breaks the taggable behavior as defined by the current specs, so will need more work before doing a PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions